You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "Rok Mihevc (Jira)" <ji...@apache.org> on 2023/01/11 07:21:04 UTC

[jira] [Commented] (ARROW-2368) DecimalVector#setBigEndian is not padding correctly for negative values

    [ https://issues.apache.org/jira/browse/ARROW-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17659395#comment-17659395 ] 

Rok Mihevc commented on ARROW-2368:
-----------------------------------

This issue has been migrated to [issue #18365|https://github.com/apache/arrow/issues/18365] on GitHub. Please see the [migration documentation|https://github.com/apache/arrow/issues/14542] for further details.

> DecimalVector#setBigEndian is not padding correctly for negative values
> -----------------------------------------------------------------------
>
>                 Key: ARROW-2368
>                 URL: https://issues.apache.org/jira/browse/ARROW-2368
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java
>            Reporter: Venki Korukanti
>            Assignee: Venki Korukanti
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> If the input given is less than 16 bytes, we pad zero for the remaining bytes [1]. This is not correct if the value is a negative number. We should pad 0x00 or 0xFF depending upon the number is a positive or negative number. Later when the value is retrieved we end up with an incorrect value.
>  
> [1] https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/DecimalVector.java#L231



--
This message was sent by Atlassian Jira
(v8.20.10#820010)