You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/14 08:12:33 UTC
[GitHub] [dolphinscheduler] caishunfeng opened a new pull request, #9503: [Improvement][doc] update time zone doc
caishunfeng opened a new pull request, #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503
## Purpose of the pull request
update time zone doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #9503: [Improvement][doc] update time zone doc
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503#discussion_r850201732
##########
docs/docs/zh/guide/howto/general-setting.md:
##########
@@ -12,8 +12,14 @@ DolphinScheduler 支持两种类型的内置主题，包括 `Dark` 和 `Light`
## 时区
-DolphinScheduler 支持时区设置。默认时区基于您运行 DolphinScheduler 服务器的时区。如果你想要切换时区，可以点击 [语言](#语言) 按钮右侧的时区按钮，
-然后点击 `请选择时区` 进行时区选择。当切换完成后，所有与时间相关的组件都将更改。
+DolphinScheduler 支持时区设置。
+
+服务时区
+
+使用脚本 `bin/dolphinshceduler_daemon.sh`启动服务， 服务的默认时区为UTC， 可以在`bin/env/dolphinscheduler_env.sh`中进行修改， 如`export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`。<br>
Review Comment:
I think we should put a url of all the time zone or list all the time zone options here. WDYT? @caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #9503: [Improvement][doc] update time zone doc
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503#discussion_r850221744
##########
docs/docs/zh/guide/howto/general-setting.md:
##########
@@ -12,8 +12,14 @@ DolphinScheduler 支持两种类型的内置主题，包括 `Dark` 和 `Light`
## 时区
-DolphinScheduler 支持时区设置。默认时区基于您运行 DolphinScheduler 服务器的时区。如果你想要切换时区，可以点击 [语言](#语言) 按钮右侧的时区按钮，
-然后点击 `请选择时区` 进行时区选择。当切换完成后，所有与时间相关的组件都将更改。
+DolphinScheduler 支持时区设置。
+
+服务时区
+
+使用脚本 `bin/dolphinshceduler_daemon.sh`启动服务， 服务的默认时区为UTC， 可以在`bin/env/dolphinscheduler_env.sh`中进行修改， 如`export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`。<br>
Review Comment:
Good idea, what about the official url of java 8:
https://docs.oracle.com/javase/8/docs/api/java/util/TimeZone.html#getAvailableIDs--
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9503: [Improvement][doc] update time zone doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503#discussion_r850373700
##########
docs/docs/en/guide/howto/general-setting.md:
##########
@@ -14,9 +14,17 @@ of to [language](#language) control button.
## Time Zone
-DolphinScheduler support time zone setting. The build-in time zone is based on the server you run DolphinScheduler. You could
+DolphinScheduler support time zone setting.
+
+Server Time Zone
Review Comment:
```suggestion
### Server Time Zone
```
##########
docs/docs/en/guide/howto/general-setting.md:
##########
@@ -14,9 +14,17 @@ of to [language](#language) control button.
## Time Zone
-DolphinScheduler support time zone setting. The build-in time zone is based on the server you run DolphinScheduler. You could
+DolphinScheduler support time zone setting.
+
+Server Time Zone
+
+The default time zone is UTC when using `bin/dolphinshceduler_daemon.sh` to start the server, you could update `SPRING_JACKSON_TIME_ZONE` in `bin/env/dolphinscheduler_env.sh`, such as `export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`.<br>
+If you start server in IDEA, the default time zone is your local time zone, you could add the JVM parameter to update server time zone, such as `-Duser.timezone=UTC`. Time zone list refer to [List of tz database time zones](https://en.wikipedia.org/wiki/List_of_tz_database_time_zones)
+
+User Time zone
Review Comment:
```suggestion
### User Time zone
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #9503: [Improvement][doc] update time zone doc
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503#issuecomment-1098832111
PTAL @Tianqi-Dotes @zhongjiajie @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #9503: [Improvement][doc] update time zone doc
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503#discussion_r850210168
##########
docs/docs/zh/guide/howto/general-setting.md:
##########
@@ -12,8 +12,14 @@ DolphinScheduler 支持两种类型的内置主题，包括 `Dark` 和 `Light`
## 时区
-DolphinScheduler 支持时区设置。默认时区基于您运行 DolphinScheduler 服务器的时区。如果你想要切换时区，可以点击 [语言](#语言) 按钮右侧的时区按钮，
-然后点击 `请选择时区` 进行时区选择。当切换完成后，所有与时间相关的组件都将更改。
+DolphinScheduler 支持时区设置。
+
+服务时区
+
+使用脚本 `bin/dolphinshceduler_daemon.sh`启动服务， 服务的默认时区为UTC， 可以在`bin/env/dolphinscheduler_env.sh`中进行修改， 如`export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`。<br>
Review Comment:
@caishunfeng What i mean is putting a link to the website that containing all time zones options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #9503: [Improvement][doc] update time zone doc
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503#discussion_r850208258
##########
docs/docs/zh/guide/howto/general-setting.md:
##########
@@ -12,8 +12,14 @@ DolphinScheduler 支持两种类型的内置主题，包括 `Dark` 和 `Light`
## 时区
-DolphinScheduler 支持时区设置。默认时区基于您运行 DolphinScheduler 服务器的时区。如果你想要切换时区，可以点击 [语言](#语言) 按钮右侧的时区按钮，
-然后点击 `请选择时区` 进行时区选择。当切换完成后，所有与时间相关的组件都将更改。
+DolphinScheduler 支持时区设置。
+
+服务时区
+
+使用脚本 `bin/dolphinshceduler_daemon.sh`启动服务， 服务的默认时区为UTC， 可以在`bin/env/dolphinscheduler_env.sh`中进行修改， 如`export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`。<br>
Review Comment:
It has so many time zones that it might be too long to here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #9503: [Improvement][doc] update time zone doc
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503#discussion_r850228172
##########
docs/docs/zh/guide/howto/general-setting.md:
##########
@@ -12,8 +12,14 @@ DolphinScheduler 支持两种类型的内置主题，包括 `Dark` 和 `Light`
## 时区
-DolphinScheduler 支持时区设置。默认时区基于您运行 DolphinScheduler 服务器的时区。如果你想要切换时区，可以点击 [语言](#语言) 按钮右侧的时区按钮，
-然后点击 `请选择时区` 进行时区选择。当切换完成后，所有与时间相关的组件都将更改。
+DolphinScheduler 支持时区设置。
+
+服务时区
+
+使用脚本 `bin/dolphinshceduler_daemon.sh`启动服务， 服务的默认时区为UTC， 可以在`bin/env/dolphinscheduler_env.sh`中进行修改， 如`export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`。<br>
Review Comment:
I think we should give the results of ```TZ database name``` directly to the users instead of letting users to learn how to use it. ```https://en.wikipedia.org/wiki/List_of_tz_database_time_zones```. @caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #9503: [Improvement][doc] update time zone doc
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503#discussion_r850239018
##########
docs/docs/zh/guide/howto/general-setting.md:
##########
@@ -12,8 +12,14 @@ DolphinScheduler 支持两种类型的内置主题，包括 `Dark` 和 `Light`
## 时区
-DolphinScheduler 支持时区设置。默认时区基于您运行 DolphinScheduler 服务器的时区。如果你想要切换时区，可以点击 [语言](#语言) 按钮右侧的时区按钮，
-然后点击 `请选择时区` 进行时区选择。当切换完成后，所有与时间相关的组件都将更改。
+DolphinScheduler 支持时区设置。
+
+服务时区
+
+使用脚本 `bin/dolphinshceduler_daemon.sh`启动服务， 服务的默认时区为UTC， 可以在`bin/env/dolphinscheduler_env.sh`中进行修改， 如`export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`。<br>
Review Comment:
>https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
I test some time zone and it's OK, I will add it into doc, thanks for your good suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng merged pull request #9503: [Improvement][doc] update time zone doc
Posted by GitBox <gi...@apache.org>.
caishunfeng merged PR #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Tianqi-Dotes commented on a diff in pull request #9503: [Improvement][doc] update time zone doc
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on code in PR #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503#discussion_r850214180
##########
docs/docs/en/guide/howto/general-setting.md:
##########
@@ -14,9 +14,17 @@ of to [language](#language) control button.
## Time Zone
-DolphinScheduler support time zone setting. The build-in time zone is based on the server you run DolphinScheduler. You could
+DolphinScheduler support time zone setting.
+
+Server Time Zone
+
+Use `bin/dolphinshceduler_daemon.sh` to start server, the default time zone is UTC, you could update `SPRING_JACKSON_TIME_ZONE` in `bin/env/dolphinscheduler_env.sh`, such as `export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`.<br>
+If you start server in idea, the default time zone is your local time zone, you could add the JVM parameter to update server time zone, such as `-Duser.timezone=UTC`.
Review Comment:
idea -> IDEA
##########
docs/docs/en/guide/howto/general-setting.md:
##########
@@ -14,9 +14,17 @@ of to [language](#language) control button.
## Time Zone
-DolphinScheduler support time zone setting. The build-in time zone is based on the server you run DolphinScheduler. You could
+DolphinScheduler support time zone setting.
+
+Server Time Zone
+
+Use `bin/dolphinshceduler_daemon.sh` to start server, the default time zone is UTC, you could update `SPRING_JACKSON_TIME_ZONE` in `bin/env/dolphinscheduler_env.sh`, such as `export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`.<br>
+If you start server in idea, the default time zone is your local time zone, you could add the JVM parameter to update server time zone, such as `-Duser.timezone=UTC`.
+
+User Time zone
+
+The user's default time zone is based on the time zone in which you run the DolphinScheduler service.You could
Review Comment:
The user's default time zone is based on the time zone in which you run the DolphinScheduler service.
->
The user's default time zone is based on the time zone of the server which runs the DolphinScheduler service.
##########
docs/docs/en/guide/howto/general-setting.md:
##########
@@ -14,9 +14,17 @@ of to [language](#language) control button.
## Time Zone
-DolphinScheduler support time zone setting. The build-in time zone is based on the server you run DolphinScheduler. You could
+DolphinScheduler support time zone setting.
+
+Server Time Zone
+
+Use `bin/dolphinshceduler_daemon.sh` to start server, the default time zone is UTC, you could update `SPRING_JACKSON_TIME_ZONE` in `bin/env/dolphinscheduler_env.sh`, such as `export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`.<br>
Review Comment:
Use `bin/dolphinshceduler_daemon.sh` to start server, the default time zone is UTC, you could update
->
The default time zone is `UTC ` when using `bin/dolphinshceduler_daemon.sh` to start the server, you could.....
##########
docs/docs/zh/guide/howto/general-setting.md:
##########
@@ -12,8 +12,14 @@ DolphinScheduler 支持两种类型的内置主题，包括 `Dark` 和 `Light`
## 时区
-DolphinScheduler 支持时区设置。默认时区基于您运行 DolphinScheduler 服务器的时区。如果你想要切换时区，可以点击 [语言](#语言) 按钮右侧的时区按钮，
-然后点击 `请选择时区` 进行时区选择。当切换完成后，所有与时间相关的组件都将更改。
+DolphinScheduler 支持时区设置。
+
+服务时区
+
+使用脚本 `bin/dolphinshceduler_daemon.sh`启动服务， 服务的默认时区为UTC， 可以在`bin/env/dolphinscheduler_env.sh`中进行修改， 如`export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`。<br>
+idea 启动服务默认时区为本地时区，可以加jvm参数如`-Duser.timezone=UTC`来修改时区。
-DolphinScheduler 内部通讯，以及任务主流程中使用 UTC 时间，在界面上显示的时间均是在 UTC 时间基础上进行时区格式化的，意味着当你切换了时区后，
-只是将格式化的时间从一个时区切换到另一个时区。
+用户时区
+
+用户的默认时区基于您运行 DolphinScheduler 服务的时区。如果你想要切换时区，可以点击 [语言](#语言) 按钮右侧的时区按钮，
Review Comment:
用户的默认时区基于您运行 DolphinScheduler 服务的时区
->
用户的默认时区基于您运行 DolphinScheduler 服务的服务器的时区
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #9503: [Improvement][doc] update time zone doc
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #9503:
URL: https://github.com/apache/dolphinscheduler/pull/9503#discussion_r850224614
##########
docs/docs/zh/guide/howto/general-setting.md:
##########
@@ -12,8 +12,14 @@ DolphinScheduler 支持两种类型的内置主题，包括 `Dark` 和 `Light`
## 时区
-DolphinScheduler 支持时区设置。默认时区基于您运行 DolphinScheduler 服务器的时区。如果你想要切换时区，可以点击 [语言](#语言) 按钮右侧的时区按钮，
-然后点击 `请选择时区` 进行时区选择。当切换完成后，所有与时间相关的组件都将更改。
+DolphinScheduler 支持时区设置。
+
+服务时区
+
+使用脚本 `bin/dolphinshceduler_daemon.sh`启动服务， 服务的默认时区为UTC， 可以在`bin/env/dolphinscheduler_env.sh`中进行修改， 如`export SPRING_JACKSON_TIME_ZONE=${SPRING_JACKSON_TIME_ZONE:-Asia/Shanghai}`。<br>
+idea 启动服务默认时区为本地时区，可以加jvm参数如`-Duser.timezone=UTC`来修改时区。
-DolphinScheduler 内部通讯，以及任务主流程中使用 UTC 时间，在界面上显示的时间均是在 UTC 时间基础上进行时区格式化的，意味着当你切换了时区后，
-只是将格式化的时间从一个时区切换到另一个时区。
+用户时区
+
+用户的默认时区基于您运行 DolphinScheduler 服务的时区。如果你想要切换时区，可以点击 [语言](#语言) 按钮右侧的时区按钮，
Review Comment:
It's base on the server time zone, not the server machine time zone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org