You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by rukaya <gi...@git.apache.org> on 2017/07/19 20:50:08 UTC

[GitHub] storm pull request #2229: Update storm.py to be python3 compatible

GitHub user rukaya opened a pull request:

    https://github.com/apache/storm/pull/2229

    Update storm.py to be python3 compatible

    Function `emitBolt()` emits a `map`, which is not json serializeble in python3. It should be changed to return a `list` in order to be json serializeble.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rukaya/storm patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2229
    
----
commit 713cbbba843bbe051de0f734f86d44e274a26a08
Author: rukaya <ru...@users.noreply.github.com>
Date:   2017-07-19T20:49:55Z

    Update storm.py to be python3 compatible
    
    Function `emitBolt()` emits a `map`, which is not json serializeble in python3. It should be changed to return a `list` in order to be json serializeble.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2229: STORM-2645 -- Update storm.py to be python3 compat...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2229: STORM-2645 -- Update storm.py to be python3 compatible

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2229
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2229: #2645 -- Update storm.py to be python3 compatible

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2229
  
    Btw I guess you filed STORM-2645. Then could you update the PR title as having STORM-2645 as prefix? Same thing applies to the commit title.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2229: #2645 -- Update storm.py to be python3 compatible

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2229
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---