You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/24 08:52:35 UTC
[GitHub] [skywalking] lihuixian001 opened a new issue #8469: [Feature] add annotations for oap.service (skywalking-kubernetes )
lihuixian001 opened a new issue #8469:
URL: https://github.com/apache/skywalking/issues/8469
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
add annotations for oap.service just like ui.service.annotations
### Use case
When opa.service.type is set to loadBalancer, you need to customize the loadBalancer by setting annotations, just like ui.service.annotations. It's a bit strange why didn't add annotations support?
```
oap:
name: oap
image:
tag: 8.9.1
storageType: elasticsearch
replicas: 2
service:
type: loadBalancer
annotations:
service.beta.kubernetes.io/alibaba-cloud-loadbalancer-id: "lb-bp16j1jvwlwxxxxxxx"
service.beta.kubernetes.io/alibaba-cloud-loadbalancer-force-override-listeners: "true"
```
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #8469: [Feature] add annotations for oap.service (skywalking-kubernetes )
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #8469:
URL: https://github.com/apache/skywalking/issues/8469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8469: [Feature] add annotations for oap.service (skywalking-kubernetes )
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8469:
URL: https://github.com/apache/skywalking/issues/8469#issuecomment-1019860467
> It's a bit strange why didn't add annotations support?
I think you didn't follow how community works. There is nothing like `why not`. The features only exist if something contributed it. That is all.
So, if you feel something is important, write a pull request with a proposal about the use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #8469: [Feature] add annotations for oap.service (skywalking-kubernetes )
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #8469:
URL: https://github.com/apache/skywalking/issues/8469#issuecomment-1019860467
> It's a bit strange why didn't add annotations support?
I think you didn't follow how community works. There is nothing like `why not`. The features only exist if someone contributed it. That is all.
So, if you feel something is important, write a pull request with a proposal about the use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org