You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ilia Shakitko <i....@tech.leaseweb.com> on 2014/09/11 15:05:23 UTC
Review Request 25537: [UI][CLOUDSTACK-7525] Add "Edit Tags"
functionality to SecurityGroup rules UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25537/
-----------------------------------------------------------
Review request for cloudstack, Brian Federle, Ian Duffy, Jessica Wang, and Nitin Mehta.
Bugs: CLOUDSTACK-7525
https://issues.apache.org/jira/browse/CLOUDSTACK-7525
Repository: cloudstack-git
Description
-------
An addition to the tagging support for security group rules: https://reviews.apache.org/r/24557/
Displays edit tags icon for every SecurityGroup Ingress/Egress rule and allows manage them.
Diffs
-----
ui/scripts/network.js 8a758c8
Diff: https://reviews.apache.org/r/25537/diff/
Testing
-------
Tested on latest master (11th of September).
Screenshots are here: https://issues.apache.org/jira/browse/CLOUDSTACK-7525
Tags can be added and deleted from UI in different browsers, no exceptions/errors.
Thanks,
Ilia Shakitko
Re: Review Request 25537: [UI][CLOUDSTACK-7525] Add "Edit Tags"
functionality to SecurityGroup rules UI
Posted by Wei Zhou <w....@leaseweb.com>.
> On 九月 11, 2014, 1:48 p.m., Wei Zhou wrote:
> > Ship It!
already committed to master and 4.4 branch
Branch: refs/heads/master
Commit: 281c866206036235790773fbcb86edede0ac739d
Parents: 4f3de02
Author: Ilia Shakitko <i....@tech.leaseweb.com>
Authored: Thu Sep 11 12:25:09 2014 +0200
Committer: Wei Zhou <w....@tech.leaseweb.com>
Committed: Thu Sep 11 15:47:21 2014 +0200
- Wei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25537/#review53031
-----------------------------------------------------------
On 九月 11, 2014, 1:06 p.m., Ilia Shakitko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25537/
> -----------------------------------------------------------
>
> (Updated 九月 11, 2014, 1:06 p.m.)
>
>
> Review request for cloudstack, Brian Federle, Ian Duffy, Jessica Wang, Nitin Mehta, Stephen Hoogendijk, and Wei Zhou.
>
>
> Bugs: CLOUDSTACK-7525
> https://issues.apache.org/jira/browse/CLOUDSTACK-7525
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> An addition to the tagging support for security group rules: https://reviews.apache.org/r/24557/
>
> Displays edit tags icon for every SecurityGroup Ingress/Egress rule and allows manage them.
>
>
> Diffs
> -----
>
> ui/scripts/network.js 8a758c8
>
> Diff: https://reviews.apache.org/r/25537/diff/
>
>
> Testing
> -------
>
> Tested on latest master (11th of September).
>
> Screenshots are here: https://issues.apache.org/jira/browse/CLOUDSTACK-7525
>
> Tags can be added and deleted from UI in different browsers, no exceptions/errors.
>
>
> Thanks,
>
> Ilia Shakitko
>
>
Re: Review Request 25537: [UI][CLOUDSTACK-7525] Add "Edit Tags"
functionality to SecurityGroup rules UI
Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25537/#review53031
-----------------------------------------------------------
Ship it!
Ship It!
- Wei Zhou
On 九月 11, 2014, 1:06 p.m., Ilia Shakitko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25537/
> -----------------------------------------------------------
>
> (Updated 九月 11, 2014, 1:06 p.m.)
>
>
> Review request for cloudstack, Brian Federle, Ian Duffy, Jessica Wang, Nitin Mehta, Stephen Hoogendijk, and Wei Zhou.
>
>
> Bugs: CLOUDSTACK-7525
> https://issues.apache.org/jira/browse/CLOUDSTACK-7525
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> An addition to the tagging support for security group rules: https://reviews.apache.org/r/24557/
>
> Displays edit tags icon for every SecurityGroup Ingress/Egress rule and allows manage them.
>
>
> Diffs
> -----
>
> ui/scripts/network.js 8a758c8
>
> Diff: https://reviews.apache.org/r/25537/diff/
>
>
> Testing
> -------
>
> Tested on latest master (11th of September).
>
> Screenshots are here: https://issues.apache.org/jira/browse/CLOUDSTACK-7525
>
> Tags can be added and deleted from UI in different browsers, no exceptions/errors.
>
>
> Thanks,
>
> Ilia Shakitko
>
>
Re: Review Request 25537: [UI][CLOUDSTACK-7525] Add "Edit Tags"
functionality to SecurityGroup rules UI
Posted by Ilia Shakitko <i....@tech.leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25537/
-----------------------------------------------------------
(Updated Sept. 11, 2014, 1:06 p.m.)
Review request for cloudstack, Brian Federle, Ian Duffy, Jessica Wang, Nitin Mehta, Stephen Hoogendijk, and Wei Zhou.
Bugs: CLOUDSTACK-7525
https://issues.apache.org/jira/browse/CLOUDSTACK-7525
Repository: cloudstack-git
Description
-------
An addition to the tagging support for security group rules: https://reviews.apache.org/r/24557/
Displays edit tags icon for every SecurityGroup Ingress/Egress rule and allows manage them.
Diffs
-----
ui/scripts/network.js 8a758c8
Diff: https://reviews.apache.org/r/25537/diff/
Testing
-------
Tested on latest master (11th of September).
Screenshots are here: https://issues.apache.org/jira/browse/CLOUDSTACK-7525
Tags can be added and deleted from UI in different browsers, no exceptions/errors.
Thanks,
Ilia Shakitko