You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/31 17:19:32 UTC

[GitHub] roywei opened a new pull request #14036: fix nightly test on tutorials

roywei opened a new pull request #14036: fix nightly test on tutorials
URL: https://github.com/apache/incubator-mxnet/pull/14036
 
 
   ## Description ##
   fix  https://github.com/apache/incubator-mxnet/issues/14026
   
   1. add scipy dependency
   2. change trainning epochs to 1 to avoid test timeout
   
   1&2 shoud fix #14026 
   
   made additional follow ups on the tutorials:
   3. change tutorial links to use website link instead of github md file links
   4. removed unecessary bash 
   5. removed bold effect in table which is not rendering correctly in [hybrid tutorial](https://mxnet.apache.org/versions/master/tutorials/gluon/hybrid.html)
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services