You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/11 07:31:44 UTC
[GitHub] [flink] dianfu opened a new pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
dianfu opened a new pull request #16777:
URL: https://github.com/apache/flink/pull/16777
## What is the purpose of the change
*This pull request supports to chain the Python DataStream operators as much as possible.*
## Verifying this change
This change added tests and can be verified as follows:
- *Added tests PythonOperatorChainingOptimizerTest*
- *Existing test cases in test_data_stream.py*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16777:
URL: https://github.com/apache/flink/pull/16777#issuecomment-896614619
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa5fc9597701558265eab5b777311baad83d3c90",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888",
"triggerID" : "fa5fc9597701558265eab5b777311baad83d3c90",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa5fc9597701558265eab5b777311baad83d3c90 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16777:
URL: https://github.com/apache/flink/pull/16777#issuecomment-896614619
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa5fc9597701558265eab5b777311baad83d3c90",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888",
"triggerID" : "fa5fc9597701558265eab5b777311baad83d3c90",
"triggerType" : "PUSH"
}, {
"hash" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa5fc9597701558265eab5b777311baad83d3c90 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888)
* d466870051d68f13029d119e1d2ae8e36fb5efcd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16777:
URL: https://github.com/apache/flink/pull/16777#issuecomment-896574565
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fa5fc9597701558265eab5b777311baad83d3c90 (Wed Aug 11 07:35:54 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16777:
URL: https://github.com/apache/flink/pull/16777#issuecomment-896614619
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa5fc9597701558265eab5b777311baad83d3c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888",
"triggerID" : "fa5fc9597701558265eab5b777311baad83d3c90",
"triggerType" : "PUSH"
}, {
"hash" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21907",
"triggerID" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"triggerType" : "PUSH"
}, {
"hash" : "a3351fa3c0f680ef03c823d0d7117f52b4e1d5f2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21943",
"triggerID" : "a3351fa3c0f680ef03c823d0d7117f52b4e1d5f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d466870051d68f13029d119e1d2ae8e36fb5efcd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21907)
* a3351fa3c0f680ef03c823d0d7117f52b4e1d5f2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21943)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on a change in pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on a change in pull request #16777:
URL: https://github.com/apache/flink/pull/16777#discussion_r686588224
##########
File path: flink-python/pyflink/datastream/stream_execution_environment.py
##########
@@ -736,8 +736,10 @@ def execute(self, job_name: str = None) -> JobExecutionResult:
:return: The result of the job execution, containing elapsed time and accumulators.
"""
+ gateway = get_gateway()
Review comment:
What about moving these logic into the method `_generate_stream_graph`
##########
File path: flink-python/pyflink/fn_execution/beam/beam_operations_fast.pxd
##########
@@ -19,9 +19,33 @@
from apache_beam.coders.coder_impl cimport StreamCoderImpl
from apache_beam.runners.worker.operations cimport Operation
+from apache_beam.utils.windowed_value cimport WindowedValue
+
+from pyflink.fn_execution.coder_impl_fast cimport InputStreamWrapper
+
+cdef class InputProcessor:
+ cpdef has_next(self)
+ cpdef next(self)
+
+cdef class NetworkInputProcessor(InputProcessor):
+ cdef InputStreamWrapper _input_stream_wrapper
+
+cdef class IntermediateInputProcessor(InputProcessor):
+ cdef object _input_values
+ cdef object _next_value
+
+cdef class OutputProcessor:
+ cpdef process_outputs(self, WindowedValue windowed_value, results)
+
+cdef class NetworkOutputProcessor(OutputProcessor):
+ cdef Operation _consumer
Review comment:
move the attribute `Operation _consumer` to the parent class `OutputProcessor` ?
##########
File path: flink-python/pyflink/fn_execution/beam/beam_operations_fast.pyx
##########
@@ -19,15 +19,85 @@
# cython: infer_types = True
# cython: profile=True
# cython: boundscheck=False, wraparound=False, initializedcheck=False, cdivision=True
+from apache_beam.runners.worker.bundle_processor import DataOutputOperation
Review comment:
move this `import` statement to the back of these `cimport` statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16777:
URL: https://github.com/apache/flink/pull/16777#issuecomment-896614619
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa5fc9597701558265eab5b777311baad83d3c90",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa5fc9597701558265eab5b777311baad83d3c90",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa5fc9597701558265eab5b777311baad83d3c90 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16777:
URL: https://github.com/apache/flink/pull/16777#issuecomment-896614619
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa5fc9597701558265eab5b777311baad83d3c90",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888",
"triggerID" : "fa5fc9597701558265eab5b777311baad83d3c90",
"triggerType" : "PUSH"
}, {
"hash" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21907",
"triggerID" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa5fc9597701558265eab5b777311baad83d3c90 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888)
* d466870051d68f13029d119e1d2ae8e36fb5efcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21907)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16777:
URL: https://github.com/apache/flink/pull/16777#issuecomment-896614619
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa5fc9597701558265eab5b777311baad83d3c90",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888",
"triggerID" : "fa5fc9597701558265eab5b777311baad83d3c90",
"triggerType" : "PUSH"
}, {
"hash" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21907",
"triggerID" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa5fc9597701558265eab5b777311baad83d3c90 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888)
* d466870051d68f13029d119e1d2ae8e36fb5efcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21907)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16777:
URL: https://github.com/apache/flink/pull/16777#issuecomment-896614619
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa5fc9597701558265eab5b777311baad83d3c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888",
"triggerID" : "fa5fc9597701558265eab5b777311baad83d3c90",
"triggerType" : "PUSH"
}, {
"hash" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21907",
"triggerID" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"triggerType" : "PUSH"
}, {
"hash" : "a3351fa3c0f680ef03c823d0d7117f52b4e1d5f2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21943",
"triggerID" : "a3351fa3c0f680ef03c823d0d7117f52b4e1d5f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a3351fa3c0f680ef03c823d0d7117f52b4e1d5f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21943)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #16777:
URL: https://github.com/apache/flink/pull/16777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16777:
URL: https://github.com/apache/flink/pull/16777#issuecomment-896614619
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa5fc9597701558265eab5b777311baad83d3c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888",
"triggerID" : "fa5fc9597701558265eab5b777311baad83d3c90",
"triggerType" : "PUSH"
}, {
"hash" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21907",
"triggerID" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d466870051d68f13029d119e1d2ae8e36fb5efcd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21907)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16777: [FLINK-23616][python] Support to chain the Python DataStream operators as much as possible
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16777:
URL: https://github.com/apache/flink/pull/16777#issuecomment-896614619
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa5fc9597701558265eab5b777311baad83d3c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21888",
"triggerID" : "fa5fc9597701558265eab5b777311baad83d3c90",
"triggerType" : "PUSH"
}, {
"hash" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21907",
"triggerID" : "d466870051d68f13029d119e1d2ae8e36fb5efcd",
"triggerType" : "PUSH"
}, {
"hash" : "a3351fa3c0f680ef03c823d0d7117f52b4e1d5f2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a3351fa3c0f680ef03c823d0d7117f52b4e1d5f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d466870051d68f13029d119e1d2ae8e36fb5efcd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21907)
* a3351fa3c0f680ef03c823d0d7117f52b4e1d5f2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org