You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/09/20 02:47:09 UTC
Review Request 68777: Set master/agent flags in
`AgentResourceProviderConfigApiTest` fixture.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68777/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jan Schlicht.
Bugs: MESOS-9228
https://issues.apache.org/jira/browse/MESOS-9228
Repository: mesos
Description
-------
Set master/agent flags in `AgentResourceProviderConfigApiTest` fixture.
Diffs
-----
src/tests/agent_resource_provider_config_api_tests.cpp e6a68bae1a9e3e773ea45deae4951664ab81a857
Diff: https://reviews.apache.org/r/68777/diff/1/
Testing
-------
make check
run tests in repetitions
Thanks,
Chun-Hung Hsiao
Re: Review Request 68777: Set master/agent flags in
`AgentResourceProviderConfigApiTest` fixture.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68777/#review208785
-----------------------------------------------------------
PASS: Mesos patch 68777 was successfully built and tested.
Reviews applied: `['68755', '68756', '68757', '68777']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2361/mesos-review-68777
- Mesos Reviewbot Windows
On Sept. 20, 2018, 2:47 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68777/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2018, 2:47 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9228
> https://issues.apache.org/jira/browse/MESOS-9228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set master/agent flags in `AgentResourceProviderConfigApiTest` fixture.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp e6a68bae1a9e3e773ea45deae4951664ab81a857
>
>
> Diff: https://reviews.apache.org/r/68777/diff/1/
>
>
> Testing
> -------
>
> make check
> run tests in repetitions
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68777: Set master/agent flags in
`AgentResourceProviderConfigApiTest` fixture.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68777/#review208842
-----------------------------------------------------------
Ship it!
src/tests/agent_resource_provider_config_api_tests.cpp
Line 88 (original), 147 (patched)
<https://reviews.apache.org/r/68777/#comment293069>
Too much syntax magic, thanks for cleaning it up.
- Benjamin Bannier
On Sept. 20, 2018, 4:47 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68777/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2018, 4:47 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9228
> https://issues.apache.org/jira/browse/MESOS-9228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set master/agent flags in `AgentResourceProviderConfigApiTest` fixture.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp e6a68bae1a9e3e773ea45deae4951664ab81a857
>
>
> Diff: https://reviews.apache.org/r/68777/diff/1/
>
>
> Testing
> -------
>
> make check
> run tests in repetitions
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>