You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/07/09 12:34:17 UTC
Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in zone
with two cluster xen and kvm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-3228
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
Shuffling the hypervisors list before getting the first hypervisor in list so that on every retry of system vm deployment it chooses different hypervisor and checking whether template is downloaded or not.
Diffs
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 407f069
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7
server/src/com/cloud/resource/ResourceManagerImpl.java 41c6ad7
server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 05256a8
Diff: https://reviews.apache.org/r/12358/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in
zone with two cluster xen and kvm
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/#review22902
-----------------------------------------------------------
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
<https://reviews.apache.org/r/12358/#comment46650>
Though this is a old comment, it is misleading, please provide a better error message.
- Abhinandan Prateek
On July 9, 2013, 10:34 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12358/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 10:34 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3228
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
>
> Shuffling the hypervisors list before getting the first hypervisor in list so that on every retry of system vm deployment it chooses different hypervisor and checking whether template is downloaded or not.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 407f069
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7
> server/src/com/cloud/resource/ResourceManagerImpl.java 41c6ad7
> server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 05256a8
>
> Diff: https://reviews.apache.org/r/12358/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in
zone with two cluster xen and kvm
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/#review24643
-----------------------------------------------------------
Commit 506f2a4b94299e626b19c17c444b2d4b3bbcc49f in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=506f2a4 ]
CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm CLOUDSTACK-3631: Enhance System vm deployment retry mechanism
Signed off by : Nitin Mehta<ni...@citrix.com>
- ASF Subversion and Git Services
On Aug. 5, 2013, 11:12 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12358/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2013, 11:12 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3228 and CLOUDSTACK-3631
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
>
> CLOUDSTACK-3631: Enhance System vm deployment retry mechanism
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java c3d44bd
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 7c6fbd0
> server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java b10fb7a
>
> Diff: https://reviews.apache.org/r/12358/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in
zone with two cluster xen and kvm
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/#review24644
-----------------------------------------------------------
Commit 40e7502bcb02a3301347f2debfb09a920306e796 in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=40e7502 ]
CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm CLOUDSTACK-3631: Enhance System vm deployment retry mechanism
Signed off by : Nitin Mehta<ni...@citrix.com>
- ASF Subversion and Git Services
On Aug. 5, 2013, 11:12 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12358/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2013, 11:12 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3228 and CLOUDSTACK-3631
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
>
> CLOUDSTACK-3631: Enhance System vm deployment retry mechanism
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java c3d44bd
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 7c6fbd0
> server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java b10fb7a
>
> Diff: https://reviews.apache.org/r/12358/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in
zone with two cluster xen and kvm
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/
-----------------------------------------------------------
(Updated Aug. 5, 2013, 11:12 a.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
rebased with master
Bugs: CLOUDSTACK-3228 and CLOUDSTACK-3631
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
CLOUDSTACK-3631: Enhance System vm deployment retry mechanism
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java c3d44bd
engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 7c6fbd0
server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java b10fb7a
Diff: https://reviews.apache.org/r/12358/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in
zone with two cluster xen and kvm
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/#review24638
-----------------------------------------------------------
Review 12358 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #111 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/111/
- Jenkins Cloudstack.org
On July 18, 2013, 9:23 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12358/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 9:23 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3228 and CLOUDSTACK-3631
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
>
> CLOUDSTACK-3631: Enhance System vm deployment retry mechanism
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java c3d44bd
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7
> server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 6859b0b
>
> Diff: https://reviews.apache.org/r/12358/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in
zone with two cluster xen and kvm
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/#review24637
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On July 18, 2013, 9:23 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12358/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 9:23 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3228 and CLOUDSTACK-3631
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
>
> CLOUDSTACK-3631: Enhance System vm deployment retry mechanism
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java c3d44bd
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7
> server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 6859b0b
>
> Diff: https://reviews.apache.org/r/12358/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in
zone with two cluster xen and kvm
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/
-----------------------------------------------------------
(Updated July 18, 2013, 9:23 a.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Updated patch based on review comments and included an enhancement on retry mechanism of system vm deployment
Bugs: CLOUDSTACK-3228 and CLOUDSTACK-3631
Repository: cloudstack-git
Description (updated)
-------
CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
CLOUDSTACK-3631: Enhance System vm deployment retry mechanism
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java c3d44bd
engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7
server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 6859b0b
Diff: https://reviews.apache.org/r/12358/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in
zone with two cluster xen and kvm
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/#review23238
-----------------------------------------------------------
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
<https://reviews.apache.org/r/12358/#comment47125>
you are logging warn n checing debug enabled ? Dont have to check that
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
<https://reviews.apache.org/r/12358/#comment47129>
Ideally, I would have liked it to be a separate function like getReadySystemTemplate(zoneId)
Also this should be a SQL query rather than embedding logic in Java
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
<https://reviews.apache.org/r/12358/#comment47126>
log it in warn
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java
<https://reviews.apache.org/r/12358/#comment47128>
In logs try to put in as much information. Put zone id and list of hypervisors you tried.
server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java
<https://reviews.apache.org/r/12358/#comment47130>
Boiler plate code.
- Nitin Mehta
On July 10, 2013, 10:56 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12358/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 10:56 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3228
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
>
> Shuffling the hypervisors list before getting the first hypervisor in list so that on every retry of system vm deployment it chooses different hypervisor and checking whether template is downloaded or not.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 407f069
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7
> server/src/com/cloud/resource/ResourceManager.java e35e89a
> server/src/com/cloud/resource/ResourceManagerImpl.java 41c6ad7
> server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 05256a8
> server/test/com/cloud/resource/MockResourceManagerImpl.java 18cff80
>
> Diff: https://reviews.apache.org/r/12358/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in
zone with two cluster xen and kvm
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/
-----------------------------------------------------------
(Updated July 10, 2013, 10:56 a.m.)
Review request for cloudstack and Nitin Mehta.
Bugs: CLOUDSTACK-3228
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
Shuffling the hypervisors list before getting the first hypervisor in list so that on every retry of system vm deployment it chooses different hypervisor and checking whether template is downloaded or not.
Diffs
-----
engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 407f069
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7
server/src/com/cloud/resource/ResourceManager.java e35e89a
server/src/com/cloud/resource/ResourceManagerImpl.java 41c6ad7
server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 05256a8
server/test/com/cloud/resource/MockResourceManagerImpl.java 18cff80
Diff: https://reviews.apache.org/r/12358/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in
zone with two cluster xen and kvm
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/
-----------------------------------------------------------
(Updated July 9, 2013, 3:02 p.m.)
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Changes
-------
Changed the way of getting right template.
Instead of shuffling the hypervisor list, we make a try on each hypervisor until it gets a right template.
Bugs: CLOUDSTACK-3228
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
Shuffling the hypervisors list before getting the first hypervisor in list so that on every retry of system vm deployment it chooses different hypervisor and checking whether template is downloaded or not.
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 407f069
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7
server/src/com/cloud/resource/ResourceManager.java e35e89a
server/src/com/cloud/resource/ResourceManagerImpl.java 41c6ad7
server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 05256a8
server/test/com/cloud/resource/MockResourceManagerImpl.java 18cff80
Diff: https://reviews.apache.org/r/12358/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in
zone with two cluster xen and kvm
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/
-----------------------------------------------------------
(Updated July 9, 2013, 10:34 a.m.)
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Bugs: CLOUDSTACK-3228
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
Shuffling the hypervisors list before getting the first hypervisor in list so that on every retry of system vm deployment it chooses different hypervisor and checking whether template is downloaded or not.
Diffs
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 407f069
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7
server/src/com/cloud/resource/ResourceManagerImpl.java 41c6ad7
server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 05256a8
Diff: https://reviews.apache.org/r/12358/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala