You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/07 22:28:20 UTC

[GitHub] [tvm] nverke commented on a diff in pull request #13147: [Hexagon] Enable Hexagon User DMA bypass mode

nverke commented on code in PR #13147:
URL: https://github.com/apache/tvm/pull/13147#discussion_r1015960910


##########
tests/python/contrib/test_hexagon/test_vtcm_bandwidth.py:
##########
@@ -95,16 +95,17 @@ def evaluate(hexagon_session, sch, size):
     )
 
     # These are reduced for CI but number=100 and repeat=10 does a good job of removing noise.
-    number = 1
-    repeat = 1
+    number = 100

Review Comment:
   I see this is a draft but make sure we do not push these changes as they would run unnecessarily slow in CI
   
   ie
   ```
       if tvm.testing.utils.IS_IN_CI:
           # Run with reduced number and repeat for CI
           timer = module.time_evaluator("__tvm_main__", hexagon_session.device, number=1, repeat=1)
       else:
           timer = module.time_evaluator("__tvm_main__", hexagon_session.device, number=10, repeat=10)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org