You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Thomas Graves (Created) (JIRA)" <ji...@apache.org> on 2012/01/18 19:44:41 UTC

[jira] [Created] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

RM web UI doesn't handle newline in job name
--------------------------------------------

                 Key: MAPREDUCE-3689
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: mrv2
    Affects Versions: 0.23.0
            Reporter: Thomas Graves
            Priority: Blocker


a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.

errors:
Uncaught SyntaxError: Unexpected token ILLEGAL
Uncaught ReferenceError: appsData is not defined

It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190421#comment-13190421 ] 

Hudson commented on MAPREDUCE-3689:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #965 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/965/])
    MAPREDUCE-3689. RM web UI doesn't handle newline in job name. (Thomas Graves via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234148
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/Jsons.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java

                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190388#comment-13190388 ] 

Hudson commented on MAPREDUCE-3689:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk #932 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/932/])
    MAPREDUCE-3689. RM web UI doesn't handle newline in job name. (Thomas Graves via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234148
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/Jsons.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java

                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190153#comment-13190153 ] 

Hudson commented on MAPREDUCE-3689:
-----------------------------------

Integrated in Hadoop-Common-0.23-Commit #399 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/399/])
    MAPREDUCE-3689. RM web UI doesn't handle newline in job name. (Thomas Graves via mahadev) - Merging r1234148 from trunk.

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234149
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/Jsons.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java

                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190398#comment-13190398 ] 

Hudson commented on MAPREDUCE-3689:
-----------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #145 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/145/])
    MAPREDUCE-3689. RM web UI doesn't handle newline in job name. (Thomas Graves via mahadev) - Merging r1234148 from trunk.

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234149
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/Jsons.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java

                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Thomas Graves (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Graves reassigned MAPREDUCE-3689:
----------------------------------------

    Assignee: Thomas Graves
    
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190183#comment-13190183 ] 

Hudson commented on MAPREDUCE-3689:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1583 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1583/])
    MAPREDUCE-3689. RM web UI doesn't handle newline in job name. (Thomas Graves via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234148
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/Jsons.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java

                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Mahadev konar (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188719#comment-13188719 ] 

Mahadev konar commented on MAPREDUCE-3689:
------------------------------------------

+1, the patch looks good. Ill wait for hudson to return before checking this in.
                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190143#comment-13190143 ] 

Hudson commented on MAPREDUCE-3689:
-----------------------------------

Integrated in Hadoop-Common-trunk-Commit #1564 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1564/])
    MAPREDUCE-3689. RM web UI doesn't handle newline in job name. (Thomas Graves via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234148
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/Jsons.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java

                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Mahadev konar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated MAPREDUCE-3689:
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.23.1
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

I just committed this. Thanks Thomas!
                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189023#comment-13189023 ] 

Hadoop QA commented on MAPREDUCE-3689:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12511039/MAPREDUCE-3689.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1628//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1628//console

This message is automatically generated.
                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Thomas Graves (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Graves updated MAPREDUCE-3689:
-------------------------------------

    Status: Patch Available  (was: Open)
    
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190142#comment-13190142 ] 

Hudson commented on MAPREDUCE-3689:
-----------------------------------

Integrated in Hadoop-Mapreduce-0.23-Commit #413 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/413/])
    MAPREDUCE-3689. RM web UI doesn't handle newline in job name. (Thomas Graves via mahadev) - Merging r1234148 from trunk.

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234149
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/Jsons.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java

                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Thomas Graves (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188703#comment-13188703 ] 

Thomas Graves commented on MAPREDUCE-3689:
------------------------------------------

tested manually since no test framework for the web ui. 
                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190413#comment-13190413 ] 

Hudson commented on MAPREDUCE-3689:
-----------------------------------

Integrated in Hadoop-Mapreduce-0.23-Build #167 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/167/])
    MAPREDUCE-3689. RM web UI doesn't handle newline in job name. (Thomas Graves via mahadev) - Merging r1234148 from trunk.

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234149
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/Jsons.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java

                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Thomas Graves (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Graves updated MAPREDUCE-3689:
-------------------------------------

    Attachment: MAPREDUCE-3689.patch

escapes the job name and also fixed another bug with the progress bar being 10000%.
                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190145#comment-13190145 ] 

Hudson commented on MAPREDUCE-3689:
-----------------------------------

Integrated in Hadoop-Hdfs-0.23-Commit #389 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/389/])
    MAPREDUCE-3689. RM web UI doesn't handle newline in job name. (Thomas Graves via mahadev) - Merging r1234148 from trunk.

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234149
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/Jsons.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java

                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3689) RM web UI doesn't handle newline in job name

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190139#comment-13190139 ] 

Hudson commented on MAPREDUCE-3689:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1638 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1638/])
    MAPREDUCE-3689. RM web UI doesn't handle newline in job name. (Thomas Graves via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234148
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/view/Jsons.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/AppsList.java

                
> RM web UI doesn't handle newline in job name
> --------------------------------------------
>
>                 Key: MAPREDUCE-3689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3689.patch
>
>
> a user submitted a mapreduce job with a newline (\n) in the job name. This caused the resource manager web ui to get a javascript exception when loading the application and scheduler pages and the pages were pretty well useless after that since they didn't load everything.  Note that this only happens when the data is returned in the JS_ARRAY, which is when you get over 100 applications.
> errors:
> Uncaught SyntaxError: Unexpected token ILLEGAL
> Uncaught ReferenceError: appsData is not defined
> It seems odd that we allow the \n in the job name.  It appears we allow it in 1.0 also, although when I ran a test the job itself failed in taskrunner. 0.23 seems to run the job fine with the \n in the job name. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira