You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by QiangCai <gi...@git.apache.org> on 2018/07/09 01:21:38 UTC

[GitHub] carbondata pull request #2459: [CARBONDATA-2705][CarbonStore] CarbonStore Ja...

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2459#discussion_r200862539
  
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -196,7 +196,7 @@ struct DataMapSchema  {
         // class name
         2: required string className;
         // to maintain properties which are mentioned in DMPROPERTIES of DDL and also it
    -    // stores properties of select query, query type like groupby, join in
    --- End diff --
    
    not required this modification.
    maybe it is a re-factory mistake.


---