You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "domhanak (via GitHub)" <gi...@apache.org> on 2024/07/26 07:06:30 UTC

[PR] Fixes based on 10.0.x-kn-plugin-workflow reviewer [incubator-kie-kogito-docs]

domhanak opened a new pull request, #667:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/667

   <!-- Please don't forget your Issue link -->
   Closes/Fixes/Resolves https://github.com/apache/incubator-kie-tools/issues/2486
   
   <!-- Please provide a short description of what this PR does -->
   **Description:**
   Fixes to improve kn plugin workflow overview docs, found during https://github.com/apache/incubator-kie-tools/issues/2486
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Fixes based on 10.0.x-kn-plugin-workflow review [incubator-kie-kogito-docs]

Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #667:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/667#discussion_r1705691838


##########
serverlessworkflow/modules/ROOT/pages/testing-and-troubleshooting/kn-plugin-workflow-overview.adoc:
##########
@@ -58,29 +64,48 @@ kn-workflow
 .Example output
 [source,text]
 ----
-Manage SonataFlow projects
+  Manage SonataFlow projects
+
+	Currently, SonataFlow targets use cases with a single Serverless Workflow main
+	file definition (i.e. workflow.sw.{json|yaml|yml}).
+
+	Additionally, you can define the configurable parameters of your application in the
+	"application.properties" file (inside the root project directory).
+	You can also store your spec files (i.e., Open API files) inside the "specs" folder,

Review Comment:
   ```suggestion
   	You can also store your spec files (i.e., OpenAPI files) inside the "specs" folder,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Fixes based on 10.0.x-kn-plugin-workflow review [incubator-kie-kogito-docs]

Posted by "domhanak (via GitHub)" <gi...@apache.org>.
domhanak commented on PR #667:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/667#issuecomment-2268835021

   We can merge this I can send a follow-up with more updates. @jakubschwan @ricardozanini fyi


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Fixes based on 10.0.x-kn-plugin-workflow review [incubator-kie-kogito-docs]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #667:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/667#issuecomment-2252113112

   🎊 PR Preview 0681c040a6f935134bff96aa37dbd8dc79bd2f0d has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-667.surge.sh
   <!-- Sticky Pull Request Comment -->
   <!-- Sticky Pull Request Comment -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] Fixes based on 10.0.x-kn-plugin-workflow review [incubator-kie-kogito-docs]

Posted by "domhanak (via GitHub)" <gi...@apache.org>.
domhanak merged PR #667:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/667


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org