You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2026/08/09 20:07:30 UTC

[PR] add hashCode impl on KafkaAsyncConsumerCommitterRef [pekko-connectors-kafka]

pjfanning opened a new pull request, #625:
URL: https://github.com/apache/pekko-connectors-kafka/pull/625

   class has a custom equals impl so should have a hashCode impl that matches it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add hashCode impl on KafkaAsyncConsumerCommitterRef [pekko-connectors-kafka]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #625:
URL: https://github.com/apache/pekko-connectors-kafka/pull/625#discussion_r3747500897


##########
tests/src/test/scala/org/apache/pekko/kafka/internal/KafkaAsyncConsumerCommitterRefSpec.scala:
##########
@@ -53,20 +53,20 @@ class KafkaAsyncConsumerCommitterRefSpec
       val ref2 = system.actorOf(Props.empty)
       val a = committer(ref1, 5.seconds)
       val b = committer(ref2, 5.seconds)
-      a should not equal b
+      (a should not).equal(b)

Review Comment:
   (this is kinda sad, but ok)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add hashCode impl on KafkaAsyncConsumerCommitterRef [pekko-connectors-kafka]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof merged PR #625:
URL: https://github.com/apache/pekko-connectors-kafka/pull/625


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org