[GitHub] [kyuubi] Yikf commented on a diff in pull request #4534: [KYUUBI #4533][AUTHZ] Cols extracted by authZ should resolve caseSensitive

["Yikf (via GitHub)" <gi...@apache.org>]

Yikf commented on code in PR #4534:
URL: https://github.com/apache/kyuubi/pull/4534#discussion_r1144730665


##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/PrivilegesBuilderSuite.scala:
##########
@@ -1687,6 +1687,26 @@ class HiveCatalogPrivilegeBuilderSuite extends PrivilegesBuilderSuite {
     assert(pi4.columns.size === 2)
     assert(pi4.columns === Seq("key", "pid"))
   }
+
+  test("KYUUBI #4533: Cols extracted by authZ should resolve caseSensitive") {
+    val plan1 = sql(s"SELECT key, pid FROM $reusedPartTable WHERE PID = '1'")
+      .queryExecution.optimizedPlan
+    val (in1, out1, _) = PrivilegesBuilder.build(plan1, spark)
+    assert(in1.size === 1)
+    assert(out1.isEmpty)
+    val pi1 = in1.head
+    assert(pi1.columns.size === 2)
+    assert(pi1.columns === Seq("key", "PID"))

Review Comment:
   Yes, we should keep consistent with raw table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org