You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/10/05 03:01:14 UTC
[GitHub] zeppelin pull request #1484: [branch-0.6] Take care of comma/tab escape in c...
GitHub user minahlee opened a pull request:
https://github.com/apache/zeppelin/pull/1484
[branch-0.6] Take care of comma/tab escape in csv/tsv download
### What is this PR for?
This PR backports #1445 to branch-0.6 since using `./dev/test_zeppelin_pr.py` throws alert for backporting it.
### What type of PR is it?
Bug Fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin branch-0.6_ZEPPELIN-1001
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1484.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1484
----
commit 574803c07c98afb544c17e5a398c0f82d92d0b55
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-09-19T11:16:12Z
Zeppelin-1001 Modified the data with comma/tab to be surronded by double quotes so that they are escaped.
commit e40407598a63d078ba12846d9790226630a8a996
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-09-29T06:59:04Z
Altered the code as per PR suggestion 1465
commit f5c7f6102962f5ba5751b4949f1623d8acb9edc6
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-09-29T07:08:40Z
Changes committed as per review comments in PR
commit 33d447c7eef447d927647427034b6ac1f74c090e
Author: meenakshisekar <me...@imaginea.com>
Date: 2016-10-03T02:31:49Z
Formatting errors corrected for build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1484: [branch-0.6] Take care of comma/tab escape in csv/tsv ...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1484
Merging it into branch-0.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1484: [branch-0.6] Take care of comma/tab escape in csv/tsv ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1484
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1484: [branch-0.6] Take care of comma/tab escape in c...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee closed the pull request at:
https://github.com/apache/zeppelin/pull/1484
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---