[GitHub] [airflow] bbovenzi commented on a change in pull request #20052: Extend config window on UI

[GitBox <gi...@apache.org>]

bbovenzi commented on a change in pull request #20052:
URL: https://github.com/apache/airflow/pull/20052#discussion_r765033942



##########
File path: airflow/www/static/js/trigger.js
##########
@@ -17,13 +17,14 @@
  * under the License.
  */
 
-/* global document, CodeMirror */
+/* global document, CodeMirror, window */
 
 const textArea = document.getElementById('json');
+const height = window.innerHeight * 0.6;

Review comment:
       ```suggestion
   const height = window.innerHeight - 450;
   ```
   Window height minus headers and footers.

##########
File path: airflow/www/static/js/trigger.js
##########
@@ -17,13 +17,14 @@
  * under the License.
  */
 
-/* global document, CodeMirror */
+/* global document, CodeMirror, window */
 
 const textArea = document.getElementById('json');
+const height = window.innerHeight * 0.6;

Review comment:
       And we should probably do a minHeight too like `height > 300 ? height : 300`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org