[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5892: [XenServer/XCP-ng] Sync the 'platform' setting according to the 'cpu.corespersocket' setting

[GitBox <gi...@apache.org>]

sureshanaparti commented on a change in pull request #5892:
URL: https://github.com/apache/cloudstack/pull/5892#discussion_r792354633



##########
File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -1899,13 +1900,25 @@ protected void fillHostInfo(final Connection conn, final StartupRoutingCommand c
         }
     }
 
+    protected void syncPlatformAndCoresPerSocketSettings(String coresPerSocket, Map<String, String> platform) {
+        if (coresPerSocket == null) {

Review comment:
       check if `coresPerSocket` is not blank ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org