You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by jh...@apache.org on 2005/06/10 20:05:12 UTC
svn commit: r189997 - in
/struts/shale/trunk/core-library/src/java/org/apache/shale: Constants.java
faces/ShaleConstants.java
Author: jholmes
Date: Fri Jun 10 11:05:11 2005
New Revision: 189997
URL: http://svn.apache.org/viewcvs?rev=189997&view=rev
Log:
Convert constants classes from interfaces to concrete classes to prevent accidental variable leak per bug #32341.
Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java
struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java
Modified: struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java
URL: http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java?rev=189997&r1=189996&r2=189997&view=diff
==============================================================================
--- struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java (original)
+++ struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java Fri Jun 10 11:05:11 2005
@@ -23,7 +23,11 @@
*
* $Id$
*/
-public interface Constants {
+public class Constants {
+ /**
+ * <p>Private constructor so that this class cannot be instantiated.</p>
+ */
+ private Constants() {}
}
Modified: struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java
URL: http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java?rev=189997&r1=189996&r2=189997&view=diff
==============================================================================
--- struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java (original)
+++ struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java Fri Jun 10 11:05:11 2005
@@ -16,9 +16,6 @@
package org.apache.shale.faces;
-import org.apache.shale.ViewController;
-import org.apache.shale.ViewControllerMapper;
-import org.apache.shale.util.TokenProcessor;
/**
* <p>{@link ShaleConstants} are manifest constants defining global identifiers shared across
@@ -27,8 +24,13 @@
*
* $Id$
*/
-public interface ShaleConstants {
+public class ShaleConstants {
+ /**
+ * <p>Private constructor so that this class cannot be instantiated.</p>
+ */
+ private ShaleConstants() {}
+
/**
* <p>Application scope attribute that's an instance of
@@ -39,7 +41,8 @@
*/
public static final String TAG_UTILITY_BEAN =
"org.apache.shale.TAG_UTILITY_BEAN";
-
+
+
/**
* <p>Appication scope attribute key under which the
* {@link TokenProcessor} instance for this application is stored.</p>
@@ -80,6 +83,4 @@
*/
public static final String VIEWS_INITIALIZED =
"org.apache.shale.faces.VIEWS_INITIALIZED";
-
-
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
RE: svn commit: r189997 - in /struts/shale/trunk/core-library/src/java/org/apache/shale: Constants.java faces/ShaleConstants.java
Posted by James Holmes <ja...@jamesholmes.com>.
Sorry about that. I must have overlooked that. I saw that you made the
fixes though so I will close out the ticket.
James
-----Original Message-----
From: Craig McClanahan [mailto:craigmcc@gmail.com]
Sent: Friday, June 10, 2005 4:26 PM
To: Struts Developers List
Cc: commits@struts.apache.org
Subject: Re: svn commit: r189997 - in
/struts/shale/trunk/core-library/src/java/org/apache/shale: Constants.java
faces/ShaleConstants.java
James,
Thanks much for all the cleanup work on Shale ... but this change
breaks the build for me. The CommonsValidatorTag class in
org.apache.shale.taglib still has "implements Constants".
Craig
On 6/10/05, jholmes@apache.org <jh...@apache.org> wrote:
> Author: jholmes
> Date: Fri Jun 10 11:05:11 2005
> New Revision: 189997
>
> URL: http://svn.apache.org/viewcvs?rev=189997&view=rev
> Log:
> Convert constants classes from interfaces to concrete classes to prevent
accidental variable leak per bug #32341.
>
> Modified:
>
struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java
>
struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstan
ts.java
>
> Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java
> URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/a
pache/shale/Constants.java?rev=189997&r1=189996&r2=189997&view=diff
>
============================================================================
==
> ---
struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java
(original)
> +++
struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java Fri
Jun 10 11:05:11 2005
> @@ -23,7 +23,11 @@
> *
> * $Id$
> */
> -public interface Constants {
> +public class Constants {
>
> + /**
> + * <p>Private constructor so that this class cannot be
instantiated.</p>
> + */
> + private Constants() {}
>
> }
>
> Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstan
ts.java
> URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/a
pache/shale/faces/ShaleConstants.java?rev=189997&r1=189996&r2=189997&view=di
ff
>
============================================================================
==
> ---
struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstan
ts.java (original)
> +++
struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstan
ts.java Fri Jun 10 11:05:11 2005
> @@ -16,9 +16,6 @@
>
> package org.apache.shale.faces;
>
> -import org.apache.shale.ViewController;
> -import org.apache.shale.ViewControllerMapper;
> -import org.apache.shale.util.TokenProcessor;
>
> /**
> * <p>{@link ShaleConstants} are manifest constants defining global
identifiers shared across
> @@ -27,8 +24,13 @@
> *
> * $Id$
> */
> -public interface ShaleConstants {
> +public class ShaleConstants {
>
> + /**
> + * <p>Private constructor so that this class cannot be
instantiated.</p>
> + */
> + private ShaleConstants() {}
> +
>
> /**
> * <p>Application scope attribute that's an instance of
> @@ -39,7 +41,8 @@
> */
> public static final String TAG_UTILITY_BEAN =
> "org.apache.shale.TAG_UTILITY_BEAN";
> -
> +
> +
> /**
> * <p>Appication scope attribute key under which the
> * {@link TokenProcessor} instance for this application is
stored.</p>
> @@ -80,6 +83,4 @@
> */
> public static final String VIEWS_INITIALIZED =
> "org.apache.shale.faces.VIEWS_INITIALIZED";
> -
> -
> }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r189997 - in /struts/shale/trunk/core-library/src/java/org/apache/shale: Constants.java faces/ShaleConstants.java
Posted by Craig McClanahan <cr...@gmail.com>.
James,
Thanks much for all the cleanup work on Shale ... but this change
breaks the build for me. The CommonsValidatorTag class in
org.apache.shale.taglib still has "implements Constants".
Craig
On 6/10/05, jholmes@apache.org <jh...@apache.org> wrote:
> Author: jholmes
> Date: Fri Jun 10 11:05:11 2005
> New Revision: 189997
>
> URL: http://svn.apache.org/viewcvs?rev=189997&view=rev
> Log:
> Convert constants classes from interfaces to concrete classes to prevent accidental variable leak per bug #32341.
>
> Modified:
> struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java
> struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java
>
> Modified: struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java
> URL: http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java?rev=189997&r1=189996&r2=189997&view=diff
> ==============================================================================
> --- struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java (original)
> +++ struts/shale/trunk/core-library/src/java/org/apache/shale/Constants.java Fri Jun 10 11:05:11 2005
> @@ -23,7 +23,11 @@
> *
> * $Id$
> */
> -public interface Constants {
> +public class Constants {
>
> + /**
> + * <p>Private constructor so that this class cannot be instantiated.</p>
> + */
> + private Constants() {}
>
> }
>
> Modified: struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java
> URL: http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java?rev=189997&r1=189996&r2=189997&view=diff
> ==============================================================================
> --- struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java (original)
> +++ struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ShaleConstants.java Fri Jun 10 11:05:11 2005
> @@ -16,9 +16,6 @@
>
> package org.apache.shale.faces;
>
> -import org.apache.shale.ViewController;
> -import org.apache.shale.ViewControllerMapper;
> -import org.apache.shale.util.TokenProcessor;
>
> /**
> * <p>{@link ShaleConstants} are manifest constants defining global identifiers shared across
> @@ -27,8 +24,13 @@
> *
> * $Id$
> */
> -public interface ShaleConstants {
> +public class ShaleConstants {
>
> + /**
> + * <p>Private constructor so that this class cannot be instantiated.</p>
> + */
> + private ShaleConstants() {}
> +
>
> /**
> * <p>Application scope attribute that's an instance of
> @@ -39,7 +41,8 @@
> */
> public static final String TAG_UTILITY_BEAN =
> "org.apache.shale.TAG_UTILITY_BEAN";
> -
> +
> +
> /**
> * <p>Appication scope attribute key under which the
> * {@link TokenProcessor} instance for this application is stored.</p>
> @@ -80,6 +83,4 @@
> */
> public static final String VIEWS_INITIALIZED =
> "org.apache.shale.faces.VIEWS_INITIALIZED";
> -
> -
> }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org