You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by "Blazer-007 (via GitHub)" <gi...@apache.org> on 2025/04/16 10:05:20 UTC

[PR] [GOBBLIN-XXX] Change aggregation temporality to DELTA instead of CUMULATIVE for Open Telemetry Metrics [gobblin]

Blazer-007 opened a new pull request, #4111:
URL: https://github.com/apache/gobblin/pull/4111

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX

### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Changed Aggregation Temporality to DELTA instead of CUMULATIVE for Open Telemetry Metrics

### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:

### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GOBBLIN-2202] Change aggregation temporality to DELTA instead of CUMULATIVE for Open Telemetry Metrics [gobblin]

Posted by "Blazer-007 (via GitHub)" <gi...@apache.org>.

Blazer-007 commented on PR #4111:
URL: https://github.com/apache/gobblin/pull/4111#issuecomment-2809171012

   More about temporality here - https://opentelemetry.io/docs/specs/otel/metrics/data-model/#temporality 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GOBBLIN-2202] Change aggregation temporality to DELTA instead of CUMULATIVE for Open Telemetry Metrics [gobblin]

Posted by "vsinghal85 (via GitHub)" <gi...@apache.org>.

vsinghal85 commented on PR #4111:
URL: https://github.com/apache/gobblin/pull/4111#issuecomment-2809233885

   Do we know why metrics were not being emitted using CUMULATIVE? In case if for some usecase we want to use CUMULATIVE, would that be something possible, or is there some blocker which prevents that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GOBBLIN-2202] Change aggregation temporality to DELTA instead of CUMULATIVE for Open Telemetry Metrics [gobblin]

Posted by "Blazer-007 (via GitHub)" <gi...@apache.org>.

Blazer-007 merged PR #4111:
URL: https://github.com/apache/gobblin/pull/4111


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GOBBLIN-2202] Change aggregation temporality to DELTA instead of CUMULATIVE for Open Telemetry Metrics [gobblin]

Posted by "abhishekmjain (via GitHub)" <gi...@apache.org>.

abhishekmjain commented on PR #4111:
URL: https://github.com/apache/gobblin/pull/4111#issuecomment-2809135502

   Will this impact consumers of the metrics working with CUMULATIVE?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GOBBLIN-2202] Change aggregation temporality to DELTA instead of CUMULATIVE for Open Telemetry Metrics [gobblin]

Posted by "Blazer-007 (via GitHub)" <gi...@apache.org>.

Blazer-007 commented on PR #4111:
URL: https://github.com/apache/gobblin/pull/4111#issuecomment-2809156775

   > Will this impact consumers of the metrics working with CUMULATIVE?
   
   Yes this will impact the users who are working with OTel collector which supports only Cumulative .
   Microsoft MDM doesn't support Cumulative specially for monotonic metrics that's why the change is required


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org