You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Amit Nithian (JIRA)" <ji...@apache.org> on 2009/04/30 19:55:30 UTC
[jira] Created: (SOLR-1136) SQLEntityProcessor- Unnecessary
while(true) in nextRow()
SQLEntityProcessor- Unnecessary while(true) in nextRow()
--------------------------------------------------------
Key: SOLR-1136
URL: https://issues.apache.org/jira/browse/SOLR-1136
Project: Solr
Issue Type: Improvement
Components: contrib - DataImportHandler
Affects Versions: 1.3
Reporter: Amit Nithian
Attachments: SOLR-1136.diff
Not sure if this is worthy of a JIRA ticket or not but there is an unnecessary while(true) in the nextRow() method in the SQLEntityProcessor. Since there is a return return statement in the loop it doesn't seem to serve a function.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1136) SQLEntityProcessor- Unnecessary
while(true) in nextRow()
Posted by "Amit Nithian (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amit Nithian updated SOLR-1136:
-------------------------------
Attachment: SOLR-1136.diff
Patch to fix this trivial improvement.
> SQLEntityProcessor- Unnecessary while(true) in nextRow()
> --------------------------------------------------------
>
> Key: SOLR-1136
> URL: https://issues.apache.org/jira/browse/SOLR-1136
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Amit Nithian
> Priority: Trivial
> Attachments: SOLR-1136.diff
>
>
> Not sure if this is worthy of a JIRA ticket or not but there is an unnecessary while(true) in the nextRow() method in the SQLEntityProcessor. Since there is a return return statement in the loop it doesn't seem to serve a function.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1136) SQLEntityProcessor- Unnecessary
while(true) in nextRow()
Posted by "Amit Nithian (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amit Nithian updated SOLR-1136:
-------------------------------
Priority: Trivial (was: Major)
> SQLEntityProcessor- Unnecessary while(true) in nextRow()
> --------------------------------------------------------
>
> Key: SOLR-1136
> URL: https://issues.apache.org/jira/browse/SOLR-1136
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Amit Nithian
> Priority: Trivial
> Attachments: SOLR-1136.diff
>
>
> Not sure if this is worthy of a JIRA ticket or not but there is an unnecessary while(true) in the nextRow() method in the SQLEntityProcessor. Since there is a return return statement in the loop it doesn't seem to serve a function.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1136) SQLEntityProcessor- Unnecessary
while(true) in nextRow()
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704906#action_12704906 ]
Noble Paul commented on SOLR-1136:
----------------------------------
makes sense. The code is the vestige of SOLR-1120
> SQLEntityProcessor- Unnecessary while(true) in nextRow()
> --------------------------------------------------------
>
> Key: SOLR-1136
> URL: https://issues.apache.org/jira/browse/SOLR-1136
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Amit Nithian
> Priority: Trivial
> Attachments: SOLR-1136.diff
>
>
> Not sure if this is worthy of a JIRA ticket or not but there is an unnecessary while(true) in the nextRow() method in the SQLEntityProcessor. Since there is a return return statement in the loop it doesn't seem to serve a function.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1136) SQLEntityProcessor- Unnecessary
while(true) in nextRow()
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar resolved SOLR-1136.
-----------------------------------------
Resolution: Fixed
Fix Version/s: 1.4
Assignee: Shalin Shekhar Mangar
Committed revision 770580.
Thanks Amit!
> SQLEntityProcessor- Unnecessary while(true) in nextRow()
> --------------------------------------------------------
>
> Key: SOLR-1136
> URL: https://issues.apache.org/jira/browse/SOLR-1136
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Amit Nithian
> Assignee: Shalin Shekhar Mangar
> Priority: Trivial
> Fix For: 1.4
>
> Attachments: SOLR-1136.diff
>
>
> Not sure if this is worthy of a JIRA ticket or not but there is an unnecessary while(true) in the nextRow() method in the SQLEntityProcessor. Since there is a return return statement in the loop it doesn't seem to serve a function.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.