You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Rampelberg <th...@saunter.org> on 2014/01/14 03:48:58 UTC
Review Request 16851: Added filtering to all tables.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Added filtering to all tables.
Diffs
-----
src/Makefile.am 22d23f455cad2d6b4cca3920443163c1219d69ef
src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
src/webui/master/static/directives/tableHeader.html PRE-CREATION
src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
Diff: https://reviews.apache.org/r/16851/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16851: Added filtering to all tables.
Posted by Ross Allen <ro...@mesosphere.io>.
> On Jan. 14, 2014, 7:37 p.m., Joe Smith wrote:
> > Mind linking a few screenshots here too? The last ones were pretty helpful, so might be a good best practice for webui RBs, but I'll defer to you guys on if we should do it going forward :)
That makes sense to me. We will get some screenshots up.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/#review31772
-----------------------------------------------------------
On Jan. 14, 2014, 2:49 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16851/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 2:49 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added filtering to all tables.
>
>
> Diffs
> -----
>
> src/Makefile.am 22d23f455cad2d6b4cca3920443163c1219d69ef
> src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
> src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
> src/webui/master/static/directives/tableHeader.html PRE-CREATION
> src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
> src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
> src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
> src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
> src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
> src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
> src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
> src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
> src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
> src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
>
> Diff: https://reviews.apache.org/r/16851/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16851: Added filtering to all tables.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/#review31772
-----------------------------------------------------------
Mind linking a few screenshots here too? The last ones were pretty helpful, so might be a good best practice for webui RBs, but I'll defer to you guys on if we should do it going forward :)
- Joe Smith
On Jan. 13, 2014, 6:49 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16851/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 6:49 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added filtering to all tables.
>
>
> Diffs
> -----
>
> src/Makefile.am 22d23f455cad2d6b4cca3920443163c1219d69ef
> src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
> src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
> src/webui/master/static/directives/tableHeader.html PRE-CREATION
> src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
> src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
> src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
> src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
> src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
> src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
> src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
> src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
> src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
> src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
>
> Diff: https://reviews.apache.org/r/16851/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16851: Added filtering to all tables.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/#review31811
-----------------------------------------------------------
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16851/#comment60518>
Yes! Why does scope in Angular have to be so painful? This is great cleanup.
- Ross Allen
On Jan. 14, 2014, 9:16 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16851/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 9:16 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added filtering to all tables.
>
> Review: http://reviews.apache.org/r/16851
>
>
> Diffs
> -----
>
> src/Makefile.am 288a5ccce8f97046500ee23b96bda8fb415e0dd5
> src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
> src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
> src/webui/master/static/directives/tableHeader.html PRE-CREATION
> src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
> src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
> src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
> src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
> src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
> src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
> src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
> src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
> src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
> src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
>
> Diff: https://reviews.apache.org/r/16851/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot 2014-01-14 12.58.45.png
> https://reviews.apache.org/media/uploaded/files/2014/01/14/683a2aee-58ac-4082-a3fe-4c65a39d4647__Screenshot_2014-01-14_12.58.45.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16851: Added filtering to all tables.
Posted by Ross Allen <ro...@mesosphere.io>.
> On Jan. 15, 2014, 7:48 p.m., Ross Allen wrote:
> > Ship It!
This has been submitted.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/#review31908
-----------------------------------------------------------
On Jan. 15, 2014, 12:22 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16851/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 12:22 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added filtering to all tables.
>
> Review: http://reviews.apache.org/r/16851
>
>
> Diffs
> -----
>
> src/Makefile.am 288a5ccce8f97046500ee23b96bda8fb415e0dd5
> src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
> src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
> src/webui/master/static/directives/tableHeader.html PRE-CREATION
> src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
> src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
> src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
> src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
> src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
> src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
> src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
> src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
> src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
> src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
>
> Diff: https://reviews.apache.org/r/16851/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot 2014-01-14 16.03.29.png
> https://reviews.apache.org/media/uploaded/files/2014/01/15/439087df-b72b-47b8-baad-c471d667609f__Screenshot_2014-01-14_16.03.29.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16851: Added filtering to all tables.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/#review31908
-----------------------------------------------------------
Ship it!
Ship It!
- Ross Allen
On Jan. 15, 2014, 12:22 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16851/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 12:22 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added filtering to all tables.
>
> Review: http://reviews.apache.org/r/16851
>
>
> Diffs
> -----
>
> src/Makefile.am 288a5ccce8f97046500ee23b96bda8fb415e0dd5
> src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
> src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
> src/webui/master/static/directives/tableHeader.html PRE-CREATION
> src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
> src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
> src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
> src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
> src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
> src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
> src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
> src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
> src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
> src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
>
> Diff: https://reviews.apache.org/r/16851/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot 2014-01-14 16.03.29.png
> https://reviews.apache.org/media/uploaded/files/2014/01/15/439087df-b72b-47b8-baad-c471d667609f__Screenshot_2014-01-14_16.03.29.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16851: Added filtering to all tables.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 12:22 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Added filtering to all tables.
Review: http://reviews.apache.org/r/16851
Diffs (updated)
-----
src/Makefile.am 288a5ccce8f97046500ee23b96bda8fb415e0dd5
src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
src/webui/master/static/directives/tableHeader.html PRE-CREATION
src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
Diff: https://reviews.apache.org/r/16851/diff/
Testing
-------
File Attachments
----------------
Screenshot 2014-01-14 16.03.29.png
https://reviews.apache.org/media/uploaded/files/2014/01/15/439087df-b72b-47b8-baad-c471d667609f__Screenshot_2014-01-14_16.03.29.png
Thanks,
Thomas Rampelberg
Re: Review Request 16851: Added filtering to all tables.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 12:05 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Added filtering to all tables.
Review: http://reviews.apache.org/r/16851
Diffs
-----
src/Makefile.am 288a5ccce8f97046500ee23b96bda8fb415e0dd5
src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
src/webui/master/static/directives/tableHeader.html PRE-CREATION
src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
Diff: https://reviews.apache.org/r/16851/diff/
Testing
-------
File Attachments (updated)
----------------
Screenshot 2014-01-14 16.03.29.png
https://reviews.apache.org/media/uploaded/files/2014/01/15/439087df-b72b-47b8-baad-c471d667609f__Screenshot_2014-01-14_16.03.29.png
Thanks,
Thomas Rampelberg
Re: Review Request 16851: Added filtering to all tables.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 12:05 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Added filtering to all tables.
Review: http://reviews.apache.org/r/16851
Diffs
-----
src/Makefile.am 288a5ccce8f97046500ee23b96bda8fb415e0dd5
src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
src/webui/master/static/directives/tableHeader.html PRE-CREATION
src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
Diff: https://reviews.apache.org/r/16851/diff/
Testing
-------
File Attachments (updated)
----------------
Screenshot 2014-01-14 12.58.45.png
https://reviews.apache.org/media/uploaded/files/2014/01/14/683a2aee-58ac-4082-a3fe-4c65a39d4647__Screenshot_2014-01-14_12.58.45.png
Screenshot 2014-01-14 16.03.29.png
https://reviews.apache.org/media/uploaded/files/2014/01/15/439087df-b72b-47b8-baad-c471d667609f__Screenshot_2014-01-14_16.03.29.png
Thanks,
Thomas Rampelberg
Re: Review Request 16851: Added filtering to all tables.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 12:05 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Added filtering to all tables.
Review: http://reviews.apache.org/r/16851
Diffs (updated)
-----
src/Makefile.am 288a5ccce8f97046500ee23b96bda8fb415e0dd5
src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
src/webui/master/static/directives/tableHeader.html PRE-CREATION
src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
Diff: https://reviews.apache.org/r/16851/diff/
Testing
-------
File Attachments
----------------
Screenshot 2014-01-14 12.58.45.png
https://reviews.apache.org/media/uploaded/files/2014/01/14/683a2aee-58ac-4082-a3fe-4c65a39d4647__Screenshot_2014-01-14_12.58.45.png
Thanks,
Thomas Rampelberg
Re: Review Request 16851: Added filtering to all tables.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 9:16 p.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Added filtering to all tables.
Review: http://reviews.apache.org/r/16851
Diffs (updated)
-----
src/Makefile.am 288a5ccce8f97046500ee23b96bda8fb415e0dd5
src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
src/webui/master/static/directives/tableHeader.html PRE-CREATION
src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
Diff: https://reviews.apache.org/r/16851/diff/
Testing
-------
File Attachments
----------------
Screenshot 2014-01-14 12.58.45.png
https://reviews.apache.org/media/uploaded/files/2014/01/14/683a2aee-58ac-4082-a3fe-4c65a39d4647__Screenshot_2014-01-14_12.58.45.png
Thanks,
Thomas Rampelberg
Re: Review Request 16851: Added filtering to all tables.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 9:14 p.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description (updated)
-------
Added filtering to all tables.
Review: http://reviews.apache.org/r/16851
Diffs (updated)
-----
3rdparty/libprocess/src/decoder.hpp a34c00512cef92b9576eee2d8017393fbcae15d7
src/Makefile.am 22d23f455cad2d6b4cca3920443163c1219d69ef
src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
src/webui/master/static/directives/tableHeader.html PRE-CREATION
src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
Diff: https://reviews.apache.org/r/16851/diff/
Testing
-------
File Attachments
----------------
Screenshot 2014-01-14 12.58.45.png
https://reviews.apache.org/media/uploaded/files/2014/01/14/683a2aee-58ac-4082-a3fe-4c65a39d4647__Screenshot_2014-01-14_12.58.45.png
Thanks,
Thomas Rampelberg
Re: Review Request 16851: Added filtering to all tables.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 9:04 p.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Added filtering to all tables.
Diffs
-----
src/Makefile.am 22d23f455cad2d6b4cca3920443163c1219d69ef
src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
src/webui/master/static/directives/tableHeader.html PRE-CREATION
src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
Diff: https://reviews.apache.org/r/16851/diff/
Testing
-------
File Attachments (updated)
----------------
Screenshot 2014-01-14 12.58.45.png
https://reviews.apache.org/media/uploaded/files/2014/01/14/683a2aee-58ac-4082-a3fe-4c65a39d4647__Screenshot_2014-01-14_12.58.45.png
Thanks,
Thomas Rampelberg
Re: Review Request 16851: Added filtering to all tables.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/#review31781
-----------------------------------------------------------
src/webui/master/static/home.html
<https://reviews.apache.org/r/16851/#comment60501>
Was this closing </div> missing before, or is this extra?
- Ross Allen
On Jan. 14, 2014, 2:49 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16851/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 2:49 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added filtering to all tables.
>
>
> Diffs
> -----
>
> src/Makefile.am 22d23f455cad2d6b4cca3920443163c1219d69ef
> src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
> src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
> src/webui/master/static/directives/tableHeader.html PRE-CREATION
> src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
> src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
> src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
> src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
> src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
> src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
> src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
> src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
> src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
> src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
>
> Diff: https://reviews.apache.org/r/16851/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16851: Added filtering to all tables.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/#review31771
-----------------------------------------------------------
* Pagination gets stuck when filtering starts. For example, if you click to page 5 and then filter down to fewer than 5 pages, the paginator stays on page 5. It seems reasonable to go back to page 1 on every key up since every character changes the result set.
* A "Clear" or "Reset" button would be nice when a filter is applied so it is easy to clear and more apparent that a filter is applied.
- Ross Allen
On Jan. 14, 2014, 2:49 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16851/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 2:49 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added filtering to all tables.
>
>
> Diffs
> -----
>
> src/Makefile.am 22d23f455cad2d6b4cca3920443163c1219d69ef
> src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
> src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
> src/webui/master/static/directives/tableHeader.html PRE-CREATION
> src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
> src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
> src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
> src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
> src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
> src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
> src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
> src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
> src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
> src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
>
> Diff: https://reviews.apache.org/r/16851/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16851: Added filtering to all tables.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/#review31792
-----------------------------------------------------------
src/webui/master/static/directives/tableHeader.html
<https://reviews.apache.org/r/16851/#comment60517>
We talked about adding a filter icon next to the form field. The markup could look like this:
<div class="input-group input-group-sm input-group-header">
<span class="input-group-addon">
<i class="glyphicon glyphicon-filter"></i>
</span>
<input type="search" ng-model="filterTerm" placeholder="Filter..."
class="filter form-control input-sm">
</div>
- Ross Allen
On Jan. 14, 2014, 2:49 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16851/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 2:49 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added filtering to all tables.
>
>
> Diffs
> -----
>
> src/Makefile.am 22d23f455cad2d6b4cca3920443163c1219d69ef
> src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
> src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
> src/webui/master/static/directives/tableHeader.html PRE-CREATION
> src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
> src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
> src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
> src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
> src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
> src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
> src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
> src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
> src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
> src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
>
> Diff: https://reviews.apache.org/r/16851/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16851: Added filtering to all tables.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/#review31757
-----------------------------------------------------------
src/webui/master/static/directives/tableHeader.html
<https://reviews.apache.org/r/16851/#comment60477>
Change to type="search" from HTML5 types.
src/webui/master/static/directives/tableHeader.html
<https://reviews.apache.org/r/16851/#comment60478>
Bootstrap has a few classes to make inputs look nicer. This could use "form-control input-sm" to get standard styles and slightly smaller padding.
Also, no need to have the self-closing tag in HTML5 for <input> elements because they have no children. The "/" can be dropped.
- Ross Allen
On Jan. 14, 2014, 2:49 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16851/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 2:49 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added filtering to all tables.
>
>
> Diffs
> -----
>
> src/Makefile.am 22d23f455cad2d6b4cca3920443163c1219d69ef
> src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
> src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
> src/webui/master/static/directives/tableHeader.html PRE-CREATION
> src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
> src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
> src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
> src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
> src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
> src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
> src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
> src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
> src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
> src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
>
> Diff: https://reviews.apache.org/r/16851/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16851: Added filtering to all tables.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16851/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 2:49 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Added filtering to all tables.
Diffs
-----
src/Makefile.am 22d23f455cad2d6b4cca3920443163c1219d69ef
src/webui/master/static/css/mesos.css e034ea04101348b8900aea3866b4250186e85e99
src/webui/master/static/directives/pagination.html dc4ad4d4fb7c19d5e3802bb6c0f4a3c5472d07bd
src/webui/master/static/directives/tableHeader.html PRE-CREATION
src/webui/master/static/framework.html 08b8afac28f252f348a2ca3ed0fcc55353373c71
src/webui/master/static/frameworks.html 29683dfd6480f8c1667adabae2e9c166e841eafc
src/webui/master/static/home.html bffd7afcf218c61f7796780e0595c50c188d4e26
src/webui/master/static/index.html f3983d23644c2df10c458505e9ff65f1fed06f9e
src/webui/master/static/js/app.js 69abe023a2c15cf0497d2c44e74c15997f074457
src/webui/master/static/offers.html 1cce0309e1268dab1e96e2cdfee81620d512b69b
src/webui/master/static/slave.html 134aa0b10a232a37654a4ef9ac4bb149dbbebdea
src/webui/master/static/slave_executor.html 81c10cbf4dd77f65dd8c3081281740c2be1e5b56
src/webui/master/static/slave_framework.html 04a041e9a4e8e1364617d09412f0a81a160ee48a
src/webui/master/static/slaves.html ec31d4b6f3235a3cc98079875295b407de06eec8
Diff: https://reviews.apache.org/r/16851/diff/
Testing
-------
Thanks,
Thomas Rampelberg