You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Filip Maj <fi...@adobe.com> on 2013/06/12 23:47:40 UTC

Re: git commit: Should install plugin after fetching from url

Tests plz!

On 6/12/13 2:25 PM, "timkim@apache.org" <ti...@apache.org> wrote:

>Updated Branches:
>  refs/heads/master 83cfd5cce -> a9af62bd2
>
>
>Should install plugin after fetching from url
>
>
>Project: http://git-wip-us.apache.org/repos/asf/cordova-plugman/repo
>Commit: 
>http://git-wip-us.apache.org/repos/asf/cordova-plugman/commit/a9af62bd
>Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugman/tree/a9af62bd
>Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugman/diff/a9af62bd
>
>Branch: refs/heads/master
>Commit: a9af62bd23707795ba7d5d0f1be4515526e11c0e
>Parents: 83cfd5c
>Author: Tim Kim <ti...@adobe.com>
>Authored: Tue Jun 11 12:33:58 2013 -0700
>Committer: Tim Kim <ti...@adobe.com>
>Committed: Tue Jun 11 12:33:58 2013 -0700
>
>----------------------------------------------------------------------
> src/fetch.js | 1 +
> 1 file changed, 1 insertion(+)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/a9af62bd/src/f
>etch.js
>----------------------------------------------------------------------
>diff --git a/src/fetch.js b/src/fetch.js
>index 68f5113..476d138 100644
>--- a/src/fetch.js
>+++ b/src/fetch.js
>@@ -32,6 +32,7 @@ module.exports = function fetchPlugin(plugin_dir,
>plugins_dir, options, callback
>             plugins.clonePluginGitRepo(plugin_dir, plugins_dir,
>options.subdir, options.git_ref, function(err, dir) {
>                 if (!err) {
>                     metadata.save_fetch_metadata(dir, data);
>+                    if (callback) callback(null, dir);
>                 }
>             });
>         }
>