[jira] [Commented] (AIRFLOW-5488) Remove unused variables from tmp_configuration_copy method

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930131#comment-16930131 ] 

ASF GitHub Bot commented on AIRFLOW-5488:
-----------------------------------------

FernandoMon commented on pull request #6114: [AIRFLOW-5488]Remove unused variables from tmp_configuration_copy method
URL: https://github.com/apache/airflow/pull/6114
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove unused variables from tmp_configuration_copy method
> ----------------------------------------------------------
>
>                 Key: AIRFLOW-5488
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5488
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: utils
>    Affects Versions: 1.10.6
>            Reporter: Jakob Homan
>            Priority: Minor
>              Labels: ccoss2019, newbie
>
> Note: This ticket's being created to facilitate a new contributor's workshop for Airflow. After the workshop has completed, I'll mark these all available for anyone that might like to take them on.
> This method for making a temporary file with configuration has two parameters, `include_env` and `include_cmds` that are never used and should be removed.
> airflow/utils/configuration.py:27
> {code:java}
> def tmp_configuration_copy(chmod=0o600, include_env=True, include_cmds=True):
>     """
>     Returns a path for a temporary file including a full copy of the configuration
>     settings.
>     :return: a path to a temporary file
>     """
>     cfg_dict = conf.as_dict(display_sensitive=True, raw=True)
>     temp_fd, cfg_path = mkstemp()
>     with os.fdopen(temp_fd, 'w') as temp_file:
>         # Set the permissions before we write anything to it.
>         if chmod is not None:
>             os.fchmod(temp_fd, chmod)
>         json.dump(cfg_dict, temp_file)
>     return cfg_path {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)