You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2017/09/26 13:10:42 UTC
[GitHub] spark pull request #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to av...
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/19352
[SPARK-22128][CORE] Update paranamer to 2.8 to avoid BytecodeReadingParanamer ArrayIndexOutOfBoundsException with Scala 2.12 + Java 8 lambda
## What changes were proposed in this pull request?
Un-manage jackson-module-paranamer version to let it use the version desired by jackson-module-scala; manage paranamer up from 2.8 for jackson-module-scala 2.7.9, to override avro 1.7.7's desired paranamer 2.3
## How was this patch tested?
Existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-22128
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19352.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19352
----
commit eaa2cf7997937df98c1bf28aed0eec7fbbe01619
Author: Sean Owen <so...@cloudera.com>
Date: 2017-09-26T13:09:34Z
Un-manage jackson-module-paranamer version to let it use the version desired by jackson-module-scala; manage paranamer up from 2.8 for jackson-module-scala 2.7.9, to override avro 1.7.7's desired paranamer 2.3
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to av...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19352
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to avoid Byt...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19352
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to avoid Byt...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19352
**[Test build #82193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82193/testReport)** for PR 19352 at commit [`eaa2cf7`](https://github.com/apache/spark/commit/eaa2cf7997937df98c1bf28aed0eec7fbbe01619).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to avoid Byt...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19352
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to avoid Byt...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19352
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to avoid Byt...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19352
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82194/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to avoid Byt...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19352
**[Test build #82194 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82194/testReport)** for PR 19352 at commit [`79451bc`](https://github.com/apache/spark/commit/79451bc70f3bf18d741f5b1593e69c41b4b5d652).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to avoid Byt...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19352
**[Test build #82193 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82193/testReport)** for PR 19352 at commit [`eaa2cf7`](https://github.com/apache/spark/commit/eaa2cf7997937df98c1bf28aed0eec7fbbe01619).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to av...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19352#discussion_r141053165
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -93,7 +93,7 @@ jackson-core-asl-1.9.13.jar
jackson-databind-2.6.7.1.jar
jackson-jaxrs-1.9.13.jar
jackson-mapper-asl-1.9.13.jar
-jackson-module-paranamer-2.6.7.jar
+jackson-module-paranamer-2.7.9.jar
--- End diff --
.. and I should say that it does look like Jackson support for Scala 2.12 really starts with 2.7.9, even though there is a special 2.6.7.1 release for Scala 2.12. It might become evident later we need to update Jackson, though it raises enough compatibility concerns that I wanted to hold off for now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to av...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19352#discussion_r141052746
--- Diff: dev/deps/spark-deps-hadoop-2.6 ---
@@ -93,7 +93,7 @@ jackson-core-asl-1.9.13.jar
jackson-databind-2.6.7.1.jar
jackson-jaxrs-1.9.13.jar
jackson-mapper-asl-1.9.13.jar
-jackson-module-paranamer-2.6.7.jar
+jackson-module-paranamer-2.7.9.jar
--- End diff --
It's weird, yes, but this is what jackson-module-paranamer-2.6.7.1 pulls in:
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-scala_2.11/2.6.7.1/jackson-module-scala_2.11-2.6.7.1.pom
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to avoid Byt...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19352
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82193/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19352: [SPARK-22128][CORE] Update paranamer to 2.8 to avoid Byt...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19352
**[Test build #82194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82194/testReport)** for PR 19352 at commit [`79451bc`](https://github.com/apache/spark/commit/79451bc70f3bf18d741f5b1593e69c41b4b5d652).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org