[jira] [Commented] (OPENNLP-1698) Switch to extjwnl in jwnl-addon

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916009#comment-17916009 ] 

ASF GitHub Bot commented on OPENNLP-1698:
-----------------------------------------

mawiesne opened a new pull request, #60:
URL: https://github.com/apache/opennlp-addons/pull/60

   Change
   -
   
   - migrates jwnl-addon to `net.sf.extjwnl` (2.0.5)
   - simplifies constructor of `JWNLLemmatizer`
   - adds new unit test: `JWNLLemmatizerTest` with line coverage > 90%
   
   Tasks
   -
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via `mvn clean install` at the root opennlp-sandbox folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](https://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp-sandbox folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp-sandbox folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   




> Switch to extjwnl in jwnl-addon
> -------------------------------
>
>                 Key: OPENNLP-1698
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1698
>             Project: OpenNLP
>          Issue Type: Task
>    Affects Versions: 2.5.3
>            Reporter: Martin Wiesner
>            Assignee: Martin Wiesner
>            Priority: Minor
>             Fix For: 2.5.4
>
>
> The jwnl-addon component relies on an ancient dependency net.sf.jwordnet#jwnl.
> There is a newer variant: [extJWNL|https://github.com/extjwnl/extjwnl] (Extended Java WordNet Library), a Java API for creating, reading and updating dictionaries in WordNet format.
> The project uses it in the sandbox components already. However, we did forget to migrate the jwnl-addon. Let's correct and align this now.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)