You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Jens Reimann (JIRA)" <ji...@apache.org> on 2018/08/07 15:24:00 UTC
[jira] [Commented] (PROTON-1911) Performance issue in
EncoderImpl#writeRaw(String)
[ https://issues.apache.org/jira/browse/PROTON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571836#comment-16571836 ]
Jens Reimann commented on PROTON-1911:
--------------------------------------
Reproducer:
{code:java}
package foo.bar;
import org.apache.qpid.proton.amqp.messaging.AmqpValue;
import org.apache.qpid.proton.message.Message;
public class Application {
private static final String DATA = "0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"
+ "0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"
+ "0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"
+ "0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"
+ "0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789";
public static void main(final String[] args) throws Exception {
final Message m = Message.Factory.create();
m.setSubject("FOO");
m.setAddress("send-to");
m.setContentType("foo/bar");
m.setBody(new AmqpValue(DATA));
final byte[] buffer = new byte[64 * 1024];
for (int i = 0; i < 1024; i++) {
m.encode(buffer, 0, buffer.length);
}
}
}
{code}
> Performance issue in EncoderImpl#writeRaw(String)
> -------------------------------------------------
>
> Key: PROTON-1911
> URL: https://issues.apache.org/jira/browse/PROTON-1911
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: proton-j-0.22.0, proton-j-0.28.0
> Reporter: Jens Reimann
> Priority: Major
> Labels: pull-request-available
> Attachments: qpid_encode_1.png, qpid_encode_2.png, qpid_encode_3.png, qpid_encode_4.png
>
>
> While digging into performance issues in the Eclipse Hono project I noticed a high consumption of CPU time when encoding AMQP messages using proton-j.
> I made a small reproducer and threw the same profiler at it, here are the results:
> As you can see in the attach screenshot (the first is the initial run with the current code) most of the time is consumed in EncoderImpl#writeRaw(String). This due to the fact that is call "put" for every byte it want to encode.
> The following screenshots are from a patched version which uses a small thread local buffer to locally encode the raw data and then flush it to the buffer in bigger chunks.
> Screenshot 3 and 4 show the improve performance, but also show that the memory consumption stays low.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org