You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2016/12/05 09:52:03 UTC
[5/5] git commit: updated refs/heads/4.9 to 8d14e8e
Merge pull request #1729 from shapeblue/vmware-memleak-fix
CLOUDSTACK-9564: Fix memory leaks in VmwareContextPoolIn a recent management server crash, it was found that the largest contributor
to memory leak was in VmwareContextPool where a registry is held (arraylist)
that grows indefinitely. The list itself is not used anywhere or consumed. There
exists a hashmap (pool) that returns a list of contexts for existing poolkey
(address/username) that is used instead.
This fixes the issue by removing the arraylist registry, and limiting the
length of the context list for a given poolkey.
@blueorangutan package
* pr/1729:
CLOUDSTACK-9564: Fix memory leaks in VmwareContextPool
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/8d14e8e8
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/8d14e8e8
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/8d14e8e8
Branch: refs/heads/4.9
Commit: 8d14e8e8b5909d4bfe0b505880eb92194e0b08a4
Parents: 3a03a01 90a3d97
Author: Rohit Yadav <ro...@shapeblue.com>
Authored: Mon Dec 5 15:15:58 2016 +0530
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Mon Dec 5 15:15:58 2016 +0530
----------------------------------------------------------------------
.../vmware/resource/VmwareContextFactory.java | 1 -
.../vmware/resource/VmwareResource.java | 2 +-
.../VmwareSecondaryStorageContextFactory.java | 1 -
.../VmwareSecondaryStorageResourceHandler.java | 2 +-
.../hypervisor/vmware/util/VmwareContext.java | 2 +-
.../vmware/util/VmwareContextPool.java | 178 +++++++++----------
.../vmware/util/VmwareContextPoolTest.java | 120 +++++++++++++
7 files changed, 210 insertions(+), 96 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/8d14e8e8/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
----------------------------------------------------------------------