You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by karensmolermiller <gi...@git.apache.org> on 2017/08/10 20:03:05 UTC
[GitHub] geode pull request #708: GEODE-3410 Doc update for gfsh query command change...
GitHub user karensmolermiller opened a pull request:
https://github.com/apache/geode/pull/708
GEODE-3410 Doc update for gfsh query command changes
- the --interactive option is gone
- there is a new --file option
- correct default value for APP_FETCH_SIZE gfsh env var
- gfsh env var APP_COLLECTION_LIMIT is no longer used
@jaredjstewart @jinmeiliao @kirklund @davebarnes97 @joeymcallister Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3410
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/708.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #708
----
commit 75ca6ab8cc41db02d0240d62ac6c034d94727e76
Author: Karen Miller <km...@pivotal.io>
Date: 2017-08-10T19:53:25Z
GEODE-3410 Doc update for gfsh query command changes
- the --interactive option is gone
- there is a new --file option
- correct default value for APP_FETCH_SIZE gfsh env var
- gfsh env var APP_COLLECTION_LIMIT is no longer used
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #708: GEODE-3410 Doc update for gfsh query command change...
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/708#discussion_r132591921
--- Diff: geode-docs/tools_modules/gfsh/command-pages/query.html.md.erb ---
@@ -21,7 +21,11 @@ limitations under the License.
Run queries against Geode regions.
-Run the specified OQL query as a single quoted string and displays results in pages allows to move between pages. If limit is not set in the query, then a default limit of 1000 (derived from GFSH environment variable APP\_FETCH\_SIZE) will be applied. Page size is derived from GFSH environment variable APP\_COLLECTION\_LIMIT (default value=20).
+If a limit restricting the result size is not set in the query,
+then a default limit of the gfsh environment variable `APP_FETCH_SIZE`
--- End diff --
Would it be much work to add a link to that section here in that case? I just suspect if I was a user I would have no idea what "the gfsh environment variable `APP_FETCH_SIZE`" means.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #708: GEODE-3410 Doc update for gfsh query command change...
Posted by karensmolermiller <gi...@git.apache.org>.
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode/pull/708#discussion_r132590875
--- Diff: geode-docs/tools_modules/gfsh/command-pages/query.html.md.erb ---
@@ -21,7 +21,11 @@ limitations under the License.
Run queries against Geode regions.
-Run the specified OQL query as a single quoted string and displays results in pages allows to move between pages. If limit is not set in the query, then a default limit of 1000 (derived from GFSH environment variable APP\_FETCH\_SIZE) will be applied. Page size is derived from GFSH environment variable APP\_COLLECTION\_LIMIT (default value=20).
+If a limit restricting the result size is not set in the query,
+then a default limit of the gfsh environment variable `APP_FETCH_SIZE`
--- End diff --
The default size is given in the gfsh section titled 'Useful gfsh Shell Variables.' I'd like to have that default value given in only 1 place in the documentation, such that if the value ever changes, we only need to update a single location. If that is OK with you, I'll consider that you approve this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #708: GEODE-3410 Doc update for gfsh query command change...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/708
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #708: GEODE-3410 Doc update for gfsh query command change...
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/708#discussion_r132589415
--- Diff: geode-docs/tools_modules/gfsh/command-pages/query.html.md.erb ---
@@ -21,7 +21,11 @@ limitations under the License.
Run queries against Geode regions.
-Run the specified OQL query as a single quoted string and displays results in pages allows to move between pages. If limit is not set in the query, then a default limit of 1000 (derived from GFSH environment variable APP\_FETCH\_SIZE) will be applied. Page size is derived from GFSH environment variable APP\_COLLECTION\_LIMIT (default value=20).
+If a limit restricting the result size is not set in the query,
+then a default limit of the gfsh environment variable `APP_FETCH_SIZE`
--- End diff --
It might be nice to also mention that `APP_FETCH_SIZE` has a default value of 100 if not explicitly set by the user.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---