You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2013/09/09 11:46:51 UTC
[jira] [Commented] (ZOOKEEPER-1750) Race condition producing NPE in
NIOServerCnxn.toString
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761729#comment-13761729 ]
Hadoop QA commented on ZOOKEEPER-1750:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12602090/0002-ZOOKEEPER-1750-trunk-version.patch
against trunk revision 1520436.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1570//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1570//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1570//console
This message is automatically generated.
> Race condition producing NPE in NIOServerCnxn.toString
> ------------------------------------------------------
>
> Key: ZOOKEEPER-1750
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1750
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.0
> Reporter: Helen Hastings
> Assignee: Rakesh R
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: 0001-ZOOKEEPER-1750-trunk-version.patch, 0002-ZOOKEEPER-1750-trunk-version.patch
>
>
> The socket is closed and the variable "sock" is set to null for normal reasons, but the toString method is called before "sock" can be set again, producing a NullPointerException.
> Stack trace:
> 2013-08-29 01:49:19,991 6277 [CommitProcWorkThread-3] WARN org.apache.zookeeper.server.WorkerService - Unexpected exception
> java.lang.NullPointerException
> at org.apach.zookeeper.server.NIOServerCnxn.toString(NIOServerCnxn.java:961)
> at java.lang.String.valueOf(String.java:2854)
> at java.lang.StringBuilder.append(StringBuilder.java:128)
> at org.apache.zookeeper.server.NIOServerCnxn.process(NIOServerCnxn.java:1104)
> at org.apache.zookeeper.server.WatchManager.triggerWatch(WatchManager.java:120)
> at org.apache.zookeeper.server.WatchManager.triggerWatch(WatchManager.java:92)
> at org.apache.zookeeper.server.DataTree.createNode(DataTree.java:544)
> at org.apache.zookeeper.server.DataTree.processTxn(DataTree.java:805)
> at org.apache.zookeeper.server.ZKDatabase.processTxn(ZKDatabase.java:319)
> at org.apache.zookeeper.server.ZooKeeperServer.processTxn(ZooKeeperServer.java:967)
> at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:115)
> at org.apache.zookeeper.server.quorum.Leader$ToBeAppliedRequestProcessor.processRequest(Leader.java:859)
> at org.apache.zookeeper.server.quorum.CommitProcessor$CommitWorkRequest.doWork(CommitProcessor.java:271)
> at org.apache.zookeeper.server.WorkerService$ScheduledWorkRequest.run(WorkerService.java:152)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:722)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira