You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/23 23:22:25 UTC

[GitHub] ChaiBapchya commented on a change in pull request #12942: Fix the operator API documentation

ChaiBapchya commented on a change in pull request #12942: Fix the operator API documentation
URL: https://github.com/apache/incubator-mxnet/pull/12942#discussion_r227598315
 
 

 ##########
 File path: src/operator/contrib/multibox_target-inl.h
 ##########
 @@ -220,13 +220,13 @@ class MultiBoxTargetProp : public OperatorProperty {
     CHECK_EQ(ashape.ndim(), 3) << "Anchor should be batch shared N*4 tensor";
     CHECK_EQ(ashape[0], 1) << "Anchors are shared across batches, first dim=1";
     CHECK_GT(ashape[1], 0) << "Number boxes should > 0";
 
 Review comment:
   nitpick: should be greater than 0
   (to keep it consistent across the doc)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services