You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/08/23 08:58:36 UTC
[PR] CAMEL-24420: camel-hazelcast - apply the default serialization filter to Camel-built client configurations [camel]
oscerd opened a new pull request, #25595:
URL: https://github.com/apache/camel/pull/25595
## What
CAMEL-23414 added `HazelcastSerializationFilterHelper.applyDefault(Config)` and applied it to the
Hazelcast configurations Camel builds itself, i.e. when the user supplies neither a `Config` nor a
`HazelcastInstance`. CAMEL-24413 then covered `ReplicatedHazelcastAggregationRepository#doStart()`,
which had been missed because it overrides `doStart()` without calling `super.doStart()`.
One Camel-built configuration path was still not covered.
`HazelcastDefaultComponent#getOrCreateHzClientInstance()` builds `new XmlClientConfigBuilder().build()`
when `hazelcastMode=client` and neither a referenced `ClientConfig` nor `hazelcastConfigUri` is supplied,
and created the client without a default `JavaSerializationFilterConfig`. The node-mode counterpart
`getOrCreateHzInstance()` has applied one since CAMEL-23414, so the two modes behaved differently for an
otherwise identical endpoint configuration.
## Changes
- Added an `applyDefault(ClientConfig)` overload to `HazelcastSerializationFilterHelper`. Both public
overloads now share a private `applyDefaultFilter(SerializationConfig)`; `ClientConfig` exposes the
same `SerializationConfig` as `Config`, so no logic is duplicated.
- Called it on the Camel-built branch of `getOrCreateHzClientInstance()`, mirroring
`getOrCreateHzInstance()`.
- Extended `HazelcastSerializationFilterHelperTest` with the two `ClientConfig` cases (default applied,
user configuration respected). The existing `handlesNullConfigGracefully` test now casts its argument,
because the new overload makes an untyped `null` ambiguous.
- Extended the existing `camel-hazelcast` section of the 4.23 upgrade guide rather than adding a second
one, so the anchor stays unique.
A user-supplied `ClientConfig` or a pre-built `HazelcastInstance` is left untouched, as established by
CAMEL-23414.
## Testing
`mvn test` in `components/camel-hazelcast`: **224/224 pass**, including the 5 helper tests and the 2
repository bootstrap tests. `mvn formatter:format impsort:sort` produces no further changes.
## Backports
Branches for `camel-4.22.x`, `camel-4.18.x` and `camel-4.14.x` are prepared and tested locally; each
stacks this change on top of the CAMEL-24413 backport, since the two edit the same upgrade-guide section.
They will be opened once this PR is merged.
JIRA: https://issues.apache.org/jira/browse/CAMEL-24420
---
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24420: camel-hazelcast - apply the default serialization filter to Camel-built client configurations [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25595:
URL: https://github.com/apache/camel/pull/25595#issuecomment-5385292456
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `components/camel-hazelcast`
- `docs`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 10 tested, 28 compile-only — current: 9 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **38 affected modules** (current approach: 9).
<details><summary>:warning: Modules only in Scalpel (29)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-lucene`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-csimple-maven-plugin`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `docs`
- `dummy-component`
</details>
**Skip-tests mode would test 10 modules** (2 direct + 8 downstream), **skip tests for 28** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (10)</summary>
- `camel-hazelcast`
- `camel-jbang-mcp`
- `camel-jbang-plugin-mcp`
- `camel-jbang-plugin-route-parser`
- `camel-jbang-plugin-tui`
- `camel-jbang-plugin-validate`
- `camel-launcher-container`
- `camel-yaml-dsl-validator`
- `camel-yaml-dsl-validator-maven-plugin`
- `docs`
</details>
<details><summary>Modules with tests skipped (28)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-lucene`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-csimple-maven-plugin`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `dummy-component`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (38 modules)</summary>
- Camel :: All Components Sync point
- Camel :: Assembly
- Camel :: Catalog :: CSimple Maven Plugin (deprecated)
- Camel :: Catalog :: Camel Catalog
- Camel :: Catalog :: Camel Report Maven Plugin
- Camel :: Catalog :: Camel Route Parser
- Camel :: Catalog :: Console
- Camel :: Catalog :: Dummy Component
- Camel :: Catalog :: Lucene (deprecated)
- Camel :: Catalog :: Maven
- Camel :: Catalog :: Suggest
- Camel :: Component DSL
- Camel :: Coverage
- Camel :: Docs
- Camel :: Endpoint DSL
- Camel :: Endpoint DSL :: Support
- Camel :: HazelCast
- Camel :: Integration Tests
- Camel :: JBang :: Core
- Camel :: JBang :: Integration tests
- Camel :: JBang :: MCP
- Camel :: JBang :: Main
- Camel :: JBang :: Plugin :: Edit
- Camel :: JBang :: Plugin :: Generate
- Camel :: JBang :: Plugin :: Kubernetes
- Camel :: JBang :: Plugin :: MCP
- Camel :: JBang :: Plugin :: Route Parser
- Camel :: JBang :: Plugin :: TUI
- Camel :: JBang :: Plugin :: Testing
- Camel :: JBang :: Plugin :: Validate
- Camel :: Kamelet Main
- Camel :: Launcher
- Camel :: Launcher :: Container
- Camel :: YAML DSL
- Camel :: YAML DSL :: Deserializers
- Camel :: YAML DSL :: Maven Plugins
- Camel :: YAML DSL :: Validator
- Camel :: YAML DSL :: Validator Maven Plugin
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/32629709938)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24420: camel-hazelcast - apply the default serialization filter to Camel-built client configurations [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25595:
URL: https://github.com/apache/camel/pull/25595#issuecomment-5385182978
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24420: camel-hazelcast - apply the default serialization filter to Camel-built client configurations [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #25595:
URL: https://github.com/apache/camel/pull/25595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org