You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2021/11/22 13:39:35 UTC

[commons-statistics] branch master updated (d7c53ab -> 5172073)

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git.


    from d7c53ab  [STATISTICS-48] Remove isSupportConnected from distribution interface
     new 3039bbe  STATISTICS-48: Remove connected property from example property file
     new 5172073  STATISTICS-48: Clarify test usage of isSupportConnected method

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../distribution/AbstractContinuousDistributionTest.java     | 12 ++----------
 .../distribution/BaseContinuousDistributionTest.java         |  2 --
 .../distribution/BaseDiscreteDistributionTest.java           |  2 --
 3 files changed, 2 insertions(+), 14 deletions(-)

[commons-statistics] 01/02: STATISTICS-48: Remove connected property from example property file

Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit 3039bbedd2ecd37daa4805ec9c936de27ab50c6b
Author: aherbert <ah...@apache.org>
AuthorDate: Mon Nov 22 13:38:13 2021 +0000

    STATISTICS-48: Remove connected property from example property file
---
 .../commons/statistics/distribution/BaseContinuousDistributionTest.java | 2 --
 .../commons/statistics/distribution/BaseDiscreteDistributionTest.java   | 2 --
 2 files changed, 4 deletions(-)

diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BaseContinuousDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BaseContinuousDistributionTest.java
index bb9bb72..a68b226 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BaseContinuousDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BaseContinuousDistributionTest.java
@@ -154,8 +154,6 @@ import org.junit.jupiter.params.provider.MethodSource;
  * lower = 0
  * # optional (default Infinity)
  * upper = Infinity
- * # optional (default true or over-ridden in isSupportConnected())
- * connected = false
  * # optional (default 1e-12 or over-ridden in getRelativeTolerance())
  * tolerance.relative = 1e-9
  * # optional (default 0.0 or over-ridden in getAbsoluteTolerance())
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BaseDiscreteDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BaseDiscreteDistributionTest.java
index 21ceeb2..a10e731 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BaseDiscreteDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BaseDiscreteDistributionTest.java
@@ -154,8 +154,6 @@ import org.junit.jupiter.params.provider.MethodSource;
  * lower = 0
  * # optional (default 2147483647, Integer.MAX_VALUE)
  * upper = max
- * # optional (default true or over-ridden in isSupportConnected())
- * connected = false
  * # optional (default 1e-12 or over-ridden in getRelativeTolerance())
  * tolerance.relative = 1e-9
  * # optional (default 0.0 or over-ridden in getAbsoluteTolerance())

[commons-statistics] 02/02: STATISTICS-48: Clarify test usage of isSupportConnected method

Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit 51720738d3452e7700496aa1a77a41556ef3f8c0
Author: aherbert <ah...@apache.org>
AuthorDate: Mon Nov 22 13:38:43 2021 +0000

    STATISTICS-48: Clarify test usage of isSupportConnected method
---
 .../distribution/AbstractContinuousDistributionTest.java     | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java
index a43395d..317f95b 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java
@@ -95,6 +95,7 @@ class AbstractContinuousDistributionTest {
 
             @Override
             public boolean isSupportConnected() {
+                // This is deliberately false; the functionality is the subject of this test
                 return false;
             }
         };
@@ -200,6 +201,7 @@ class AbstractContinuousDistributionTest {
 
             @Override
             public boolean isSupportConnected() {
+                // This is deliberately false; the functionality is the subject of this test
                 return false;
             }
         };
@@ -278,11 +280,6 @@ class AbstractContinuousDistributionTest {
             public double getSupportUpperBound() {
                 return Double.POSITIVE_INFINITY;
             }
-
-            @Override
-            public boolean isSupportConnected() {
-                return true;
-            }
         };
         double x = distribution.inverseCumulativeProbability(0.5);
         // The value can be anything other than x0
@@ -355,11 +352,6 @@ class AbstractContinuousDistributionTest {
                 // Report upper bound incorrectly (it should be 10) to test cdf(1)
                 return Double.POSITIVE_INFINITY;
             }
-
-            @Override
-            public boolean isSupportConnected() {
-                return true;
-            }
         };
 
         // Accuracy is dependent on the tolerance of the solver