You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/10/10 16:59:27 UTC

Review Request 26556: Incorrect behavior of creating config groups

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26556/
-----------------------------------------------------------

Review request for Ambari and Andriy Babiichuk.


Bugs: AMBARI-7726
    https://issues.apache.org/jira/browse/AMBARI-7726


Repository: ambari


Description
-------

Is present two-node vagrant cluster with all started services.
Steps:
1 Go to HDFS configs.
2 Create config group and assign one host to it.
3 Select created group and override "DataNode maximum Java heap size" property.
4 Create other config group and assign one host to it.

Result: after close config groups manager was opened config tab for created group. "DataNode maximum Java heap size" property has default and first group's values, but does not has "Override" button.


Diffs
-----

  ambari-web/app/controllers/main/service/info/configs.js 386ec96 

Diff: https://reviews.apache.org/r/26556/diff/


Testing
-------

tested on real cluster


Thanks,

Aleksandr Kovalenko


Re: Review Request 26556: Incorrect behavior of creating config groups

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26556/#review56143
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Окт. 10, 2014, 2:59 п.п., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26556/
> -----------------------------------------------------------
> 
> (Updated Окт. 10, 2014, 2:59 п.п.)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: AMBARI-7726
>     https://issues.apache.org/jira/browse/AMBARI-7726
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Is present two-node vagrant cluster with all started services.
> Steps:
> 1 Go to HDFS configs.
> 2 Create config group and assign one host to it.
> 3 Select created group and override "DataNode maximum Java heap size" property.
> 4 Create other config group and assign one host to it.
> 
> Result: after close config groups manager was opened config tab for created group. "DataNode maximum Java heap size" property has default and first group's values, but does not has "Override" button.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/info/configs.js 386ec96 
> 
> Diff: https://reviews.apache.org/r/26556/diff/
> 
> 
> Testing
> -------
> 
> tested on real cluster
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>


Re: Review Request 26556: Incorrect behavior of creating config groups

Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26556/#review56144
-----------------------------------------------------------

Ship it!


Ship It!

- Andrii Tkach


On Окт. 10, 2014, 2:59 п.п., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26556/
> -----------------------------------------------------------
> 
> (Updated Окт. 10, 2014, 2:59 п.п.)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: AMBARI-7726
>     https://issues.apache.org/jira/browse/AMBARI-7726
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Is present two-node vagrant cluster with all started services.
> Steps:
> 1 Go to HDFS configs.
> 2 Create config group and assign one host to it.
> 3 Select created group and override "DataNode maximum Java heap size" property.
> 4 Create other config group and assign one host to it.
> 
> Result: after close config groups manager was opened config tab for created group. "DataNode maximum Java heap size" property has default and first group's values, but does not has "Override" button.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/info/configs.js 386ec96 
> 
> Diff: https://reviews.apache.org/r/26556/diff/
> 
> 
> Testing
> -------
> 
> tested on real cluster
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>