You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Ajit Kumar <aj...@hortonworks.com> on 2016/04/29 21:52:54 UTC
Review Request 46812: Topology host info is not cleared when a host is
removed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46812/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Daniel Gergely, and Sumit Mohanty.
Bugs: AMBARI-15457
https://issues.apache.org/jira/browse/AMBARI-15457
Repository: ambari
Description
-------
As part of https://issues.apache.org/jira/browse/AMBARI-15457, code was added to clear topology hostinfo https://git1-us-west.apache.org/repos/asf?p=ambari.git;a=blobdiff;f=ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java;h=1ffd3aa63e5cc0bbd40310634f0e400a2793b36a;hp=6251f07bc96bbf28a2b68efb16fb4a8cdec56184;hb=a6dd447b0878029197f00b2f4cd34adba88e5d47;hpb=b65b7c2ddbe6e11d8c0514346f2c00da3feceaae.
Function call to clear topology info was reverted in https://git1-us-west.apache.org/repos/asf?p=ambari.git;a=blobdiff;f=ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java;h=4dc47be06385cc9dc3467030cfb21b91f5b4fb9d;hp=2bd16640a659030246a15615896760bde3fdbd87;hb=cc10ec0b4acdfb522ff193fc66f777aa82b9f6be;hpb=5af48693efa2dad3b702f64f87e6daaec253c869 by mistake, while fixing merge conflict. This patch adds function call and fixes unit test cases for the same.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 56ef28b762cde7f097e68eb97695203c1a7b7bb1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java 3a2fdb2699df3ea1f3822f049b73249a12bee393
Diff: https://reviews.apache.org/r/46812/diff/
Testing
-------
Unit tests
Thanks,
Ajit Kumar
Re: Review Request 46812: Topology host info is not cleared when a
host is removed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46812/#review131224
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 29, 2016, 7:52 p.m., Ajit Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46812/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 7:52 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Daniel Gergely, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15457
> https://issues.apache.org/jira/browse/AMBARI-15457
>
>
> Repository: ambari
>
>
> Description
> -------
>
> As part of https://issues.apache.org/jira/browse/AMBARI-15457, code was added to clear topology hostinfo https://git1-us-west.apache.org/repos/asf?p=ambari.git;a=blobdiff;f=ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java;h=1ffd3aa63e5cc0bbd40310634f0e400a2793b36a;hp=6251f07bc96bbf28a2b68efb16fb4a8cdec56184;hb=a6dd447b0878029197f00b2f4cd34adba88e5d47;hpb=b65b7c2ddbe6e11d8c0514346f2c00da3feceaae.
>
> Function call to clear topology info was reverted in https://git1-us-west.apache.org/repos/asf?p=ambari.git;a=blobdiff;f=ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java;h=4dc47be06385cc9dc3467030cfb21b91f5b4fb9d;hp=2bd16640a659030246a15615896760bde3fdbd87;hb=cc10ec0b4acdfb522ff193fc66f777aa82b9f6be;hpb=5af48693efa2dad3b702f64f87e6daaec253c869 by mistake, while fixing merge conflict. This patch adds function call and fixes unit test cases for the same.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 56ef28b762cde7f097e68eb97695203c1a7b7bb1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java 3a2fdb2699df3ea1f3822f049b73249a12bee393
>
> Diff: https://reviews.apache.org/r/46812/diff/
>
>
> Testing
> -------
>
> Unit tests
>
>
> Thanks,
>
> Ajit Kumar
>
>