You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/06/28 18:16:16 UTC
[GitHub] [jackrabbit-oak] anchela opened a new pull request, #609: OAK-9819 : Improve Node.hasProperty/getProperty and Node.hasNode/getNode combinations
anchela opened a new pull request, #609:
URL: https://github.com/apache/jackrabbit-oak/pull/609
@joerghoh , @reschke , @mreutegg , would you have time to take a look this improvement? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] reschke commented on pull request #609: OAK-9819 : Improve Node.hasProperty/getProperty and Node.hasNode/getNode combinations
Posted by GitBox <gi...@apache.org>.
reschke commented on PR #609:
URL: https://github.com/apache/jackrabbit-oak/pull/609#issuecomment-1169696914
Ok...
But can we have a default impl in the interface (that just catches Exceptions and returns null)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] anchela commented on pull request #609: OAK-9819 : Improve Node.hasProperty/getProperty and Node.hasNode/getNode combinations
Posted by GitBox <gi...@apache.org>.
anchela commented on PR #609:
URL: https://github.com/apache/jackrabbit-oak/pull/609#issuecomment-1172226796
@joerghoh , just wanted to see if i can invite you for reviews now.... :-) *works*. please approve or request changes....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] anchela commented on pull request #609: OAK-9819 : Improve Node.hasProperty/getProperty and Node.hasNode/getNode combinations
Posted by GitBox <gi...@apache.org>.
anchela commented on PR #609:
URL: https://github.com/apache/jackrabbit-oak/pull/609#issuecomment-1170880207
@mreutegg , unless you have any concerns i would go ahead a merge the improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] anchela commented on pull request #609: OAK-9819 : Improve Node.hasProperty/getProperty and Node.hasNode/getNode combinations
Posted by GitBox <gi...@apache.org>.
anchela commented on PR #609:
URL: https://github.com/apache/jackrabbit-oak/pull/609#issuecomment-1171402378
@mreutegg , good catch! i fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] joerghoh merged pull request #609: OAK-9819 : Improve Node.hasProperty/getProperty and Node.hasNode/getNode combinations
Posted by GitBox <gi...@apache.org>.
joerghoh merged PR #609:
URL: https://github.com/apache/jackrabbit-oak/pull/609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org