You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Charlie Groves (JIRA)" <ji...@apache.org> on 2008/01/18 00:23:35 UTC
[jira] Created: (PIG-65) convert tabs to spaces
convert tabs to spaces
----------------------
Key: PIG-65
URL: https://issues.apache.org/jira/browse/PIG-65
Project: Pig
Issue Type: Bug
Reporter: Charlie Groves
Priority: Minor
Many of the pig source files mix tabs and 4 spaces. This is particularly painful for me when reading the code as I've set up my editor to indent tabs 8 spaces so I can catch if I actually use them anywhere, and the source jumps back and forth in indentation level, sometimes from line to line.
The patch replaces all tabs with 4 spaces in java code since that's what's mentioned as the standard in the wiki.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (PIG-65) convert tabs to spaces
Posted by Charlie Groves <ch...@threerings.net>.
I just wrote a little tab to space Python script, so I can rerun that
and make a new patch whenever it's convenient to merge a change like
this in.
Charlie
On Jan 23, 2008, at 11:03 AM, Antonio Magnaghi wrote:
> If possible I'd this patch to be applied after the Abstraction
> Layer has
> been merged onto the trunk. That'll make the review work much easier.
>
> Thanks,
> -a.
>
> -----Original Message-----
> From: Charlie Groves (JIRA) [mailto:jira@apache.org]
> Sent: Thursday, January 17, 2008 3:26 PM
> To: pig-dev@incubator.apache.org
> Subject: [jira] Updated: (PIG-65) convert tabs to spaces
>
>
> [
> https://issues.apache.org/jira/browse/PIG-65?
> page=com.atlassian.jira.plu
> gin.system.issuetabpanels:all-tabpanel ]
>
> Charlie Groves updated PIG-65:
> ------------------------------
>
> Attachment: tabs_to_spaces.diff
>
>> convert tabs to spaces
>> ----------------------
>>
>> Key: PIG-65
>> URL: https://issues.apache.org/jira/browse/PIG-65
>> Project: Pig
>> Issue Type: Bug
>> Reporter: Charlie Groves
>> Priority: Minor
>> Attachments: tabs_to_spaces.diff
>>
>>
>> Many of the pig source files mix tabs and 4 spaces for indentation.
> This is particularly painful for me when reading the code as I've
> set up
> my editor to indent tabs 8 spaces so I can catch if I actually use
> them
> anywhere, and the source jumps back and forth in indentation level,
> sometimes from line to line.
>> The patch replaces all tabs with 4 spaces in java code since that's
> what's mentioned as the standard in the wiki.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
RE: [jira] Updated: (PIG-65) convert tabs to spaces
Posted by Antonio Magnaghi <an...@yahoo-inc.com>.
If possible I'd this patch to be applied after the Abstraction Layer has
been merged onto the trunk. That'll make the review work much easier.
Thanks,
-a.
-----Original Message-----
From: Charlie Groves (JIRA) [mailto:jira@apache.org]
Sent: Thursday, January 17, 2008 3:26 PM
To: pig-dev@incubator.apache.org
Subject: [jira] Updated: (PIG-65) convert tabs to spaces
[
https://issues.apache.org/jira/browse/PIG-65?page=com.atlassian.jira.plu
gin.system.issuetabpanels:all-tabpanel ]
Charlie Groves updated PIG-65:
------------------------------
Attachment: tabs_to_spaces.diff
> convert tabs to spaces
> ----------------------
>
> Key: PIG-65
> URL: https://issues.apache.org/jira/browse/PIG-65
> Project: Pig
> Issue Type: Bug
> Reporter: Charlie Groves
> Priority: Minor
> Attachments: tabs_to_spaces.diff
>
>
> Many of the pig source files mix tabs and 4 spaces for indentation.
This is particularly painful for me when reading the code as I've set up
my editor to indent tabs 8 spaces so I can catch if I actually use them
anywhere, and the source jumps back and forth in indentation level,
sometimes from line to line.
> The patch replaces all tabs with 4 spaces in java code since that's
what's mentioned as the standard in the wiki.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: PIG-65
Posted by Alan Gates <ga...@yahoo-inc.com>.
The one line also notes that those coding conventions can be found
here: http://java.sun.com/docs/codeconv/
Alan.
Olga Natkovich wrote:
> We have 1 line in HowToContribute page saying that we follow Sun
> Conventions :)
>
> Olga
>
>
>> -----Original Message-----
>> From: Arun C Murthy [mailto:acm@yahoo-inc.com]
>> Sent: Wednesday, February 06, 2008 3:22 PM
>> To: pig-dev@incubator.apache.org
>> Subject: Re: PIG-65
>>
>>
>> On Feb 6, 2008, at 3:11 PM, Olga Natkovich wrote:
>>
>>
>>> Hi,
>>>
>>> I just committed PIG-65 which converts tabs to spaces to match our
>>> coding standard. This means that if you have any
>>>
>> outstanding patch to
>>
>>> a java file(s), it needs to be regenerated.
>>>
>>>
>> Better now than later I guess - we did this much later over
>> at Hadoop and that hurt 'svn annotate' no end... sigh!
>>
>> I'd think this is a good time to impose other coding
>> conventions (are they documented somewhere?) e.g.
>> 80-character limit on each line etc.
>>
>> thanks,
>> Arun
>>
>>
>>
RE: PIG-65
Posted by Olga Natkovich <ol...@yahoo-inc.com>.
We have 1 line in HowToContribute page saying that we follow Sun
Conventions :)
Olga
> -----Original Message-----
> From: Arun C Murthy [mailto:acm@yahoo-inc.com]
> Sent: Wednesday, February 06, 2008 3:22 PM
> To: pig-dev@incubator.apache.org
> Subject: Re: PIG-65
>
>
> On Feb 6, 2008, at 3:11 PM, Olga Natkovich wrote:
>
> >
> > Hi,
> >
> > I just committed PIG-65 which converts tabs to spaces to match our
> > coding standard. This means that if you have any
> outstanding patch to
> > a java file(s), it needs to be regenerated.
> >
>
> Better now than later I guess - we did this much later over
> at Hadoop and that hurt 'svn annotate' no end... sigh!
>
> I'd think this is a good time to impose other coding
> conventions (are they documented somewhere?) e.g.
> 80-character limit on each line etc.
>
> thanks,
> Arun
>
>
Re: PIG-65
Posted by Arun C Murthy <ac...@yahoo-inc.com>.
On Feb 6, 2008, at 3:11 PM, Olga Natkovich wrote:
>
> Hi,
>
> I just committed PIG-65 which converts tabs to spaces to match our
> coding standard. This means that if you have any outstanding patch
> to a
> java file(s), it needs to be regenerated.
>
Better now than later I guess - we did this much later over at Hadoop
and that hurt 'svn annotate' no end... sigh!
I'd think this is a good time to impose other coding conventions (are
they documented somewhere?) e.g. 80-character limit on each line etc.
thanks,
Arun
PIG-65
Posted by Olga Natkovich <ol...@yahoo-inc.com>.
Hi,
I just committed PIG-65 which converts tabs to spaces to match our
coding standard. This means that if you have any outstanding patch to a
java file(s), it needs to be regenerated.
Thanks,
Olga
[jira] Commented: (PIG-65) convert tabs to spaces
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560168#action_12560168 ]
Benjamin Reed commented on PIG-65:
----------------------------------
+1 Thank you!!!
> convert tabs to spaces
> ----------------------
>
> Key: PIG-65
> URL: https://issues.apache.org/jira/browse/PIG-65
> Project: Pig
> Issue Type: Bug
> Reporter: Charlie Groves
> Priority: Minor
> Attachments: tabs_to_spaces.diff
>
>
> Many of the pig source files mix tabs and 4 spaces for indentation. This is particularly painful for me when reading the code as I've set up my editor to indent tabs 8 spaces so I can catch if I actually use them anywhere, and the source jumps back and forth in indentation level, sometimes from line to line.
> The patch replaces all tabs with 4 spaces in java code since that's what's mentioned as the standard in the wiki.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-65) convert tabs to spaces
Posted by "Charlie Groves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charlie Groves updated PIG-65:
------------------------------
Attachment: tabs_to_spaces.diff
> convert tabs to spaces
> ----------------------
>
> Key: PIG-65
> URL: https://issues.apache.org/jira/browse/PIG-65
> Project: Pig
> Issue Type: Bug
> Reporter: Charlie Groves
> Priority: Minor
> Attachments: tabs_to_spaces.diff
>
>
> Many of the pig source files mix tabs and 4 spaces for indentation. This is particularly painful for me when reading the code as I've set up my editor to indent tabs 8 spaces so I can catch if I actually use them anywhere, and the source jumps back and forth in indentation level, sometimes from line to line.
> The patch replaces all tabs with 4 spaces in java code since that's what's mentioned as the standard in the wiki.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIG-65) convert tabs to spaces
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich resolved PIG-65.
-------------------------------
Resolution: Fixed
patch committed
> convert tabs to spaces
> ----------------------
>
> Key: PIG-65
> URL: https://issues.apache.org/jira/browse/PIG-65
> Project: Pig
> Issue Type: Bug
> Reporter: Charlie Groves
> Priority: Minor
> Attachments: tabs_to_spaces.diff, tabs_to_spaces_post_PIG-32.diff
>
>
> Many of the pig source files mix tabs and 4 spaces for indentation. This is particularly painful for me when reading the code as I've set up my editor to indent tabs 8 spaces so I can catch if I actually use them anywhere, and the source jumps back and forth in indentation level, sometimes from line to line.
> The patch replaces all tabs with 4 spaces in java code since that's what's mentioned as the standard in the wiki.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-65) convert tabs to spaces
Posted by "Charlie Groves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566382#action_12566382 ]
Charlie Groves commented on PIG-65:
-----------------------------------
That revision is across the entire Apache repository. It's 619193 now. Pig still hasn't changed since 619153.
> convert tabs to spaces
> ----------------------
>
> Key: PIG-65
> URL: https://issues.apache.org/jira/browse/PIG-65
> Project: Pig
> Issue Type: Bug
> Reporter: Charlie Groves
> Priority: Minor
> Attachments: tabs_to_spaces.diff, tabs_to_spaces_post_PIG-32.diff
>
>
> Many of the pig source files mix tabs and 4 spaces for indentation. This is particularly painful for me when reading the code as I've set up my editor to indent tabs 8 spaces so I can catch if I actually use them anywhere, and the source jumps back and forth in indentation level, sometimes from line to line.
> The patch replaces all tabs with 4 spaces in java code since that's what's mentioned as the standard in the wiki.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-65) convert tabs to spaces
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566372#action_12566372 ]
Olga Natkovich commented on PIG-65:
-----------------------------------
The current revision that I see is 619182.
> convert tabs to spaces
> ----------------------
>
> Key: PIG-65
> URL: https://issues.apache.org/jira/browse/PIG-65
> Project: Pig
> Issue Type: Bug
> Reporter: Charlie Groves
> Priority: Minor
> Attachments: tabs_to_spaces.diff, tabs_to_spaces_post_PIG-32.diff
>
>
> Many of the pig source files mix tabs and 4 spaces for indentation. This is particularly painful for me when reading the code as I've set up my editor to indent tabs 8 spaces so I can catch if I actually use them anywhere, and the source jumps back and forth in indentation level, sometimes from line to line.
> The patch replaces all tabs with 4 spaces in java code since that's what's mentioned as the standard in the wiki.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-65) convert tabs to spaces
Posted by "Charlie Groves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charlie Groves updated PIG-65:
------------------------------
Description:
Many of the pig source files mix tabs and 4 spaces for indentation. This is particularly painful for me when reading the code as I've set up my editor to indent tabs 8 spaces so I can catch if I actually use them anywhere, and the source jumps back and forth in indentation level, sometimes from line to line.
The patch replaces all tabs with 4 spaces in java code since that's what's mentioned as the standard in the wiki.
was:
Many of the pig source files mix tabs and 4 spaces. This is particularly painful for me when reading the code as I've set up my editor to indent tabs 8 spaces so I can catch if I actually use them anywhere, and the source jumps back and forth in indentation level, sometimes from line to line.
The patch replaces all tabs with 4 spaces in java code since that's what's mentioned as the standard in the wiki.
> convert tabs to spaces
> ----------------------
>
> Key: PIG-65
> URL: https://issues.apache.org/jira/browse/PIG-65
> Project: Pig
> Issue Type: Bug
> Reporter: Charlie Groves
> Priority: Minor
> Attachments: tabs_to_spaces.diff
>
>
> Many of the pig source files mix tabs and 4 spaces for indentation. This is particularly painful for me when reading the code as I've set up my editor to indent tabs 8 spaces so I can catch if I actually use them anywhere, and the source jumps back and forth in indentation level, sometimes from line to line.
> The patch replaces all tabs with 4 spaces in java code since that's what's mentioned as the standard in the wiki.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-65) convert tabs to spaces
Posted by "Charlie Groves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charlie Groves updated PIG-65:
------------------------------
Attachment: tabs_to_spaces_post_PIG-32.diff
Here's a version of the patch for trunk as of r619153.
> convert tabs to spaces
> ----------------------
>
> Key: PIG-65
> URL: https://issues.apache.org/jira/browse/PIG-65
> Project: Pig
> Issue Type: Bug
> Reporter: Charlie Groves
> Priority: Minor
> Attachments: tabs_to_spaces.diff, tabs_to_spaces_post_PIG-32.diff
>
>
> Many of the pig source files mix tabs and 4 spaces for indentation. This is particularly painful for me when reading the code as I've set up my editor to indent tabs 8 spaces so I can catch if I actually use them anywhere, and the source jumps back and forth in indentation level, sometimes from line to line.
> The patch replaces all tabs with 4 spaces in java code since that's what's mentioned as the standard in the wiki.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-65) convert tabs to spaces
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566340#action_12566340 ]
Olga Natkovich commented on PIG-65:
-----------------------------------
Charlie, we have committed changes for PIG-32 which were blocking your patch. Could you generate a new patch, thanks!
> convert tabs to spaces
> ----------------------
>
> Key: PIG-65
> URL: https://issues.apache.org/jira/browse/PIG-65
> Project: Pig
> Issue Type: Bug
> Reporter: Charlie Groves
> Priority: Minor
> Attachments: tabs_to_spaces.diff
>
>
> Many of the pig source files mix tabs and 4 spaces for indentation. This is particularly painful for me when reading the code as I've set up my editor to indent tabs 8 spaces so I can catch if I actually use them anywhere, and the source jumps back and forth in indentation level, sometimes from line to line.
> The patch replaces all tabs with 4 spaces in java code since that's what's mentioned as the standard in the wiki.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.