You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/10 00:37:00 UTC

[GitHub] [tvm] rkimball commented on a change in pull request #7431: Many fixes to get unit tests passing on Windows.

rkimball commented on a change in pull request #7431:
URL: https://github.com/apache/tvm/pull/7431#discussion_r573355807



##########
File path: python/tvm/contrib/cc.py
##########
@@ -212,9 +214,9 @@ def _linux_compile(output, objects, options, compile_cmd="g++", compile_shared=F
         raise RuntimeError(msg)
 
 
-def _windows_shared(output, objects, options):
+def _windows_compile(output, objects, options):
     cmd = ["clang"]
-    cmd += ["-O2", "-flto=full", "-fuse-ld=lld-link"]
+    cmd += ["-O2", "-v", "-fvisibility=default", "-export-all-symbols"]

Review comment:
       Yes, there are some debug flags in there too, -v. That line needs to be cleaned up.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org