[GitHub] tonysun83 commented on a change in pull request #476: Couchdb 3376 fix mem3 shards

[gi...@git.apache.org]

tonysun83 commented on a change in pull request #476: Couchdb 3376 fix mem3 shards
URL: https://github.com/apache/couchdb/pull/476#discussion_r112602608
 
 

 ##########
 File path: src/mem3/src/mem3_shards.erl
 ##########
 @@ -249,6 +269,21 @@ code_change(_OldVsn, #st{}=St, _Extra) ->
 
 %% internal functions
 
+start_changes_listener(SinceSeq) ->
 
 Review comment:
   these references confused me a bit...but if iiuc, we're spawning a separate process to check if the mem3_shards process died, and once it does, we terminate the listen_for_changes process that was spawned by mem3_shards? If that's the case, what's the purpose behind this? Before we were just monitoring it.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services