You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/07/07 22:00:55 UTC
Re: Review Request: FLUME-1161 Logging output says name:null after
initiating agent shutdown
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5349/#review8945
-----------------------------------------------------------
Could you please rebase this patch? It is not applying cleanly. Thanks.
trunk/flume-ng-core/src/main/java/org/apache/flume/CounterGroup.java
<https://reviews.apache.org/r/5349/#comment19004>
Nit: A more "pure" way of doing this would be to call the other constructor:
this(null);
- Hari Shreedharan
On June 27, 2012, 12:56 a.m., Mubarak Seyed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5349/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 12:56 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Logging output says name:null after initiating agent shutdown. Source and Sink will call setName() of CounterGroup.
>
>
> This addresses bug FLUME-1161.
> https://issues.apache.org/jira/browse/FLUME-1161
>
>
> Diffs
> -----
>
> trunk/flume-ng-core/src/main/java/org/apache/flume/CounterGroup.java 1351026
> trunk/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 1351026
> trunk/flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java 1351026
> trunk/flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java 1351026
> trunk/flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 1351026
> trunk/flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 1351026
> trunk/flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 1351026
> trunk/flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java 1351026
> trunk/flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 1351026
> trunk/flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java 1351026
> trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 1351026
> trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 1351026
> trunk/flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java 1351026
> trunk/flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java 1351026
>
> Diff: https://reviews.apache.org/r/5349/diff/
>
>
> Testing
> -------
>
> Yes, unit tested.
>
>
> Thanks,
>
> Mubarak Seyed
>
>