You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/11/30 17:53:59 UTC

[GitHub] incubator-brooklyn pull request: Fix itest/pom: include BROOKLYN_V...

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1077

    Fix itest/pom: include BROOKLYN_VERSION marker

    Also follows convention used in other poms, to include relativePath
    for parent, and to declare the artifactId+name before the parent.
    
    The `BROOKLYN_VERSION` fix is very important for our release process, so we can easily update the version number everywhere.
    
    Out of interest @CMoH why does kara/pom.xml depend on brooklyn rather than brooklyn-parent? I have not changed that here.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/itest-version

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1077.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1077
    
----
commit 95e5e59fdbdb79b447d8929f17204dc8ab018db2
Author: Aled Sage <al...@gmail.com>
Date:   2015-11-30T16:51:54Z

    Fix itest/pom: include BROOKLYN_VERSION marker
    
    Also follows convention used in other poms, to include relativePath
    for parent, and to declare the artifactId+name before the parent.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix itest/pom: include BROOKLYN_V...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/1077


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix itest/pom: include BROOKLYN_V...

Posted by CMoH <gi...@git.apache.org>.
Github user CMoH commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1077#issuecomment-160825476
  
    Thanks for your input, @aledsage . LGTM. Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---