You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekrb19 (via GitHub)" <gi...@apache.org> on 2024/02/06 06:54:07 UTC
[PR] Update `groupId` for delta-lake and iceberg extensions (druid)
abhishekrb19 opened a new pull request, #15843:
URL: https://github.com/apache/druid/pull/15843
This PR:
- Updates the `groupId` for both delta-lake and iceberg extensions to `org.apache.druid.extensions.contrib`; all the other contrib extensions already have this group id
- Includes both delta-lake and iceberg extensions in `extensions.md`
- Updates the codeblocks in the `extensions.md` for syntax highlighting and IDE support
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update `groupId` for delta-lake and iceberg extensions (druid)
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on PR #15843:
URL: https://github.com/apache/druid/pull/15843#issuecomment-1930109224
Builds are failing. Change LGTM otherwise. I think it will be helpful to also change the docs for delta and iceberg extension with instructions on how to fetch the extension. I have seen people trip over that. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update `groupId` for delta-lake and iceberg extensions (druid)
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on PR #15843:
URL: https://github.com/apache/druid/pull/15843#issuecomment-1931524428
> I think it will be helpful to also change the docs for delta and iceberg extension with instructions on how to fetch the extension. I have seen people trip over that. What do you think?
Good idea. I included a small section in the delta lake and iceberg docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update `groupId` for delta-lake and iceberg extensions (druid)
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 merged PR #15843:
URL: https://github.com/apache/druid/pull/15843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update `groupId` for delta-lake and iceberg extensions (druid)
Posted by "abhishekrb19 (via GitHub)" <gi...@apache.org>.
abhishekrb19 commented on PR #15843:
URL: https://github.com/apache/druid/pull/15843#issuecomment-1933531546
Merging the PR as the IT failure is unrelated:
```
[standard-its / (Compile=openjdk8, Run=openjdk8, Cluster Build On K8s) ITNestedQueryPushDownTest integration test](https://github.com/apache/druid/actions/runs/7820090484/job/21337518879?pr=15843#logs)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org