You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sébastien Brisard (JIRA)" <ji...@apache.org> on 2012/05/31 07:44:23 UTC
[jira] [Created] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Sébastien Brisard created MATH-795:
--------------------------------------
Summary: Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
Key: MATH-795
URL: https://issues.apache.org/jira/browse/MATH-795
Project: Commons Math
Issue Type: Bug
Affects Versions: 3.1
Reporter: Sébastien Brisard
Assignee: Sébastien Brisard
Priority: Minor
Fix For: 3.1
The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408644#comment-13408644 ]
Sébastien Brisard edited comment on MATH-795 at 7/12/12 2:05 PM:
-----------------------------------------------------------------
As of {{r1358547}}, refactoring should be complete. This refactring revealed some bugs, see MATH-812 and MATH-821.
was (Author: celestin):
As of {{r1358547}}, refactoring should be complete. This refactring revealed some bugs, see MATH-812.
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287858#comment-13287858 ]
Sébastien Brisard commented on MATH-795:
----------------------------------------
Factored out {{testBasicFunctions()}} in {{r1345443}}.
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287158#comment-13287158 ]
Sébastien Brisard commented on MATH-795:
----------------------------------------
Thanks for the hint. Once I've finished cleaning up what's already in there, I'll take a look at Mahout.
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289924#comment-13289924 ]
Sébastien Brisard commented on MATH-795:
----------------------------------------
As of {{r1346725}}, all tests have been factored out. Some of these tests now need to be split in smaller units.
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408257#comment-13408257 ]
Sébastien Brisard commented on MATH-795:
----------------------------------------
JIRA work log tab no longer works. Below is the list of all commits relevant to this ticket
* {{r1358049}}
* {{r1358048}}
* {{r1358046}}
* {{r1358044}}
* {{r1358033}}
* {{r1356576}}
* {{r1356070}}
* {{r1354822}}
* {{r1354330}}
* {{r1354329}}
* {{r1353825}}
* {{r1353824}}
* {{r1353388}}
* {{r1353387}}
* {{r1348485}}
* {{r1348438}}
* {{r1348228}}
* {{r1348225}}
* {{r1348211}}
* {{r1347883}}
* {{r1347877}}
* {{r1347717}}
* {{r1347401}}
* {{r1347395}}
* {{r1346741}}
* {{r1346740}}
* {{r1346729}}
* {{r1346725}}
* {{r1346723}}
* {{r1346523}}
* {{r1346475}}
* {{r1346471}}
* {{r1346467}}
* {{r1346245}}
* {{r1346243}}
* {{r1346240}}
* {{r1345837}}
* {{r1345443}}
* {{r1344989}}
* {{r1344571}}
* {{r1344570}}
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sébastien Brisard resolved MATH-795.
------------------------------------
Resolution: Fixed
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408257#comment-13408257 ]
Sébastien Brisard edited comment on MATH-795 at 7/7/12 5:18 AM:
----------------------------------------------------------------
JIRA work log tab no longer works. Below is the list of all commits relevant to this ticket
* {{r1358049}}
* {{r1358048}}
* {{r1358046}}
* {{r1358044}}
* {{r1358033}}
* {{r1356576}}
* {{r1356070}}
* {{r1354822}}
* {{r1354330}}
* {{r1354329}}
* {{r1353825}}
* {{r1353824}}
* {{r1353388}}
* {{r1353387}}
* {{r1348485}}
* {{r1348438}}
* {{r1348228}}
* {{r1348225}}
* {{r1348211}}
* {{r1347883}}
* {{r1347877}}
* {{r1347717}}
* {{r1347401}}
* {{r1347395}}
* {{r1346741}}
* {{r1346740}}
* {{r1346729}}
* {{r1346725}}
* {{r1346723}}
* {{r1346523}}
* {{r1346475}}
* {{r1346471}}
* {{r1346467}}
* {{r1346245}}
* {{r1346243}}
* {{r1346240}}
* {{r1345837}}
* {{r1345443}}
* {{r1344989}}
* {{r1344571}}
* {{r1344570}}
* {{r1358502}}
was (Author: celestin):
JIRA work log tab no longer works. Below is the list of all commits relevant to this ticket
* {{r1358049}}
* {{r1358048}}
* {{r1358046}}
* {{r1358044}}
* {{r1358033}}
* {{r1356576}}
* {{r1356070}}
* {{r1354822}}
* {{r1354330}}
* {{r1354329}}
* {{r1353825}}
* {{r1353824}}
* {{r1353388}}
* {{r1353387}}
* {{r1348485}}
* {{r1348438}}
* {{r1348228}}
* {{r1348225}}
* {{r1348211}}
* {{r1347883}}
* {{r1347877}}
* {{r1347717}}
* {{r1347401}}
* {{r1347395}}
* {{r1346741}}
* {{r1346740}}
* {{r1346729}}
* {{r1346725}}
* {{r1346723}}
* {{r1346523}}
* {{r1346475}}
* {{r1346471}}
* {{r1346467}}
* {{r1346245}}
* {{r1346243}}
* {{r1346240}}
* {{r1345837}}
* {{r1345443}}
* {{r1344989}}
* {{r1344571}}
* {{r1344570}}
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Ted Dunning (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286379#comment-13286379 ]
Ted Dunning commented on MATH-795:
----------------------------------
Mahout has an extensive set of tests that work this way for both Vectors and Matrices. Might be worth a look to see if there is anything worth stealing. Having an inheritable test makes it MUCH easier to get a new kind of vector or matrix right.
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408644#comment-13408644 ]
Sébastien Brisard commented on MATH-795:
----------------------------------------
As of {{r1358547}}, refactoring should be complete. This refactring revealed some bugs, see MATH-812.
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287160#comment-13287160 ]
Sébastien Brisard commented on MATH-795:
----------------------------------------
Factored out testMapFunctions() in {{r1344989}}.
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sébastien Brisard updated MATH-795:
-----------------------------------
Issue Type: Improvement (was: Bug)
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-795) Refactoring ArrayRealVectorTest,
RealVectorTest, SparseRealVectorTest
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286349#comment-13286349 ]
Sébastien Brisard commented on MATH-795:
----------------------------------------
Factored out {{testDataInOut()}} in {{r1344571}}.
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
> Key: MATH-795
> URL: https://issues.apache.org/jira/browse/MATH-795
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Priority: Minor
> Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller units.
> Besides readability, the benefit would be to ease the implementation of other kinds of vector. This refactoring should also lead to a natural resolution of MATH-625.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira