[PR] Fix MSRV violation in `parse.rs` test, check `--all-targets` in MSRV CI [arrow-rs-object-store]

["alamb (via GitHub)" <gi...@apache.org>]

alamb opened a new pull request, #837:
URL: https://github.com/apache/arrow-rs-object-store/pull/837

   # Which issue does this PR close?
   
   N/A — follow-up to a report by @progval in https://github.com/apache/arrow-rs-object-store/pull/812#issuecomment-5061268463
   
   # Rationale for this change
   
   `str::from_utf8` (the associated function on the `str` primitive, as opposed to the `std::str::from_utf8` module function) was only stabilized in Rust 1.87, but this crate's MSRV is 1.85. Compiling tests with Rust 1.85 fails:
   
   ```
   error[E0599]: no function or associated item named `from_utf8` found for type `str` in the current scope
      --> src/parse.rs:477:25
       |
   477 |         let body = str::from_utf8(&body).unwrap();
       |                         ^^^^^^^^^ function or associated item not found in `str`
   ```
   
   CI did not catch this because the MSRV job runs `cargo msrv verify`, whose default check command (`cargo check`) only compiles the library target — `#[cfg(test)]` code is never compiled with the MSRV toolchain.
   
   # What changes are included in this PR?
   
   1. Use `std::str::from_utf8` in the test so it compiles on Rust 1.85
   2. Pass a custom check command to `cargo msrv verify` (`cargo check --all-targets --all-features`) so tests, examples, and benches are also verified against the MSRV
   
   # Are these changes tested?
   
   Yes, verified locally:
   - `cargo +1.85 check --all-targets --all-features` fails on `main` and passes with this PR
   - `cargo msrv verify --output-format=json -- cargo check --all-targets --all-features` (the new CI command) fails on `main` and passes with this PR, confirming the CI change would have caught the regression
   
   # Are there any user-facing changes?
   
   No, test and CI changes only.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix MSRV violation in `parse.rs` test, check `--all-targets` in MSRV CI [arrow-rs-object-store]

["kylebarron (via GitHub)" <gi...@apache.org>]

kylebarron merged PR #837:
URL: https://github.com/apache/arrow-rs-object-store/pull/837


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org