You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2015/04/02 23:24:48 UTC

[2/4] hbase git commit: HBASE-13388 Handling NullPointer in ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)

HBASE-13388 Handling NullPointer in ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/6605dda7
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/6605dda7
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/6605dda7

Branch: refs/heads/branch-1
Commit: 6605dda7b40a7dab8cf6a2188ed5086dd3d39def
Parents: 3c0e398
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Apr 2 14:17:26 2015 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Apr 2 14:18:07 2015 -0700

----------------------------------------------------------------------
 .../org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/6605dda7/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
index a13292e..387c2e4 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
@@ -200,7 +200,6 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
     Subprocedure subproc = null;
     try {
       byte[] data = ZKUtil.getData(zkController.getWatcher(), path);
-      LOG.debug("start proc data length is " + data.length);
       if (!ProtobufUtil.isPBMagicPrefix(data)) {
         String msg = "Data in for starting procuedure " + opName +
           " is illegally formatted (no pb magic). " +
@@ -208,6 +207,7 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
         LOG.error(msg);
         throw new IllegalArgumentException(msg);
       }
+      LOG.debug("start proc data length is " + data.length);
       data = Arrays.copyOfRange(data, ProtobufUtil.lengthOfPBMagic(), data.length);
       LOG.debug("Found data for znode:" + path);
       subproc = member.createSubprocedure(opName, data);