You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/09/22 01:48:17 UTC
Review Request 38582: Removed the unneeded container work directory
mounts.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38582/
-----------------------------------------------------------
Review request for mesos, Jojy Varghese, Timothy Chen, and Jiang Yan Xu.
Bugs: MESOS-3483
https://issues.apache.org/jira/browse/MESOS-3483
Repository: mesos
Description
-------
Removed the unneeded container work directory mounts.
Because of r38569, the container's work directory self bind mount (when rootfs is not used) is no longer needed.
Diffs
-----
src/slave/containerizer/isolators/filesystem/linux.cpp f1e6f7519bdeeff7790fff63e7a9cb3075001758
Diff: https://reviews.apache.org/r/38582/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 38582: Removed the unneeded container work
directory mounts.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38582/#review99907
-----------------------------------------------------------
Bad patch!
Reviews applied: [38569]
Failed command: ./support/apply-review.sh -n -r 38569
Error:
2015-09-22 02:17:48 URL:https://reviews.apache.org/r/38569/diff/raw/ [5637/5637] -> "38569.patch" [1]
error: patch failed: src/slave/containerizer/isolators/filesystem/linux.cpp:31
error: src/slave/containerizer/isolators/filesystem/linux.cpp: patch does not apply
error: patch failed: src/tests/environment.cpp:21
error: src/tests/environment.cpp: patch does not apply
error: patch failed: src/tests/utils.cpp:72
error: src/tests/utils.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Sept. 21, 2015, 11:48 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38582/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 11:48 p.m.)
>
>
> Review request for mesos, Jojy Varghese, Timothy Chen, and Jiang Yan Xu.
>
>
> Bugs: MESOS-3483
> https://issues.apache.org/jira/browse/MESOS-3483
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed the unneeded container work directory mounts.
>
> Because of r38569, the container's work directory self bind mount (when rootfs is not used) is no longer needed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/filesystem/linux.cpp f1e6f7519bdeeff7790fff63e7a9cb3075001758
>
> Diff: https://reviews.apache.org/r/38582/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 38582: Removed the unneeded container work
directory mounts.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38582/#review99875
-----------------------------------------------------------
Ship it!
src/slave/containerizer/isolators/filesystem/linux.cpp (lines 810 - 812)
<https://reviews.apache.org/r/38582/#comment156892>
Change to past tense? "container was not launched", etc.
- Jiang Yan Xu
On Sept. 21, 2015, 4:48 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38582/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 4:48 p.m.)
>
>
> Review request for mesos, Jojy Varghese, Timothy Chen, and Jiang Yan Xu.
>
>
> Bugs: MESOS-3483
> https://issues.apache.org/jira/browse/MESOS-3483
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed the unneeded container work directory mounts.
>
> Because of r38569, the container's work directory self bind mount (when rootfs is not used) is no longer needed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/filesystem/linux.cpp f1e6f7519bdeeff7790fff63e7a9cb3075001758
>
> Diff: https://reviews.apache.org/r/38582/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>