You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/12/17 00:32:59 UTC
[GitHub] [incubator-gobblin] ZihanLi58 opened a new pull request #3180: Fix the data loss issue caused by the cache expiration in PartitionerDataWriter
ZihanLi58 opened a new pull request #3180:
URL: https://github.com/apache/incubator-gobblin/pull/3180
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1343
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Problem statement:
Previously, we maintain a cache in PartitionedDataWriter to avoid accumulate writer in memory in long running job. But when we expire the writer, we only close it without flush/commit, so it may cause data loss when there is a slowness happening on HDFS.
Potential solution:
In the removal logic, we can make sure the writer has been committed correctly, i.e. force it to commit before close. But the issue here is we still remove the writer from cache, so next flush message will be handled and return without call commit for the right writer, and watermark will move without data being published to HDFS.
We calculate the time for the write operation, and if it takes a long time, we force to add the writer back to cache so that next flush message will be picked up by the writer.
Here we use the second solution
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #3180: Fix the data loss issue caused by the cache expiration in PartitionerDataWriter
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #3180:
URL: https://github.com/apache/incubator-gobblin/pull/3180#discussion_r547496790
##########
File path: gobblin-core/src/main/java/org/apache/gobblin/writer/PartitionedDataWriter.java
##########
@@ -235,18 +239,24 @@ private boolean isDataWriterWatermarkCapable(DataWriter<D> dataWriter) {
@Override
public void writeEnvelope(RecordEnvelope<D> recordEnvelope) throws IOException {
try {
- DataWriter<D> writer = getDataWriterForRecord(recordEnvelope.getRecord());
+ GenericRecord partition = getPartitionForRecord(recordEnvelope.getRecord());
+ DataWriter<D> writer = this.partitionWriters.get(partition);
+ long startTime = System.currentTimeMillis();
writer.writeEnvelope(recordEnvelope);
- } catch (ExecutionException ee) {
+ long timeForWriting = System.currentTimeMillis() - startTime;
+ // If the write take a long time, which is 1/3 of cache expiration time, we fail the writer to avoid data loss
+ // and further slowness on the same HDFS block
+ if (timeForWriting > this.writeTimeoutInterval ) {
+ throw new TimeoutException(StringFormatter.format("Write record took %s ms, but threshold is %s ms",
Review comment:
If you will need to catch the `TimeoutException` later again and re-throw as IOE, why not directly throw IOE ?
##########
File path: gobblin-core/src/main/java/org/apache/gobblin/writer/PartitionedDataWriter.java
##########
@@ -17,6 +17,7 @@
package org.apache.gobblin.writer;
+import com.sun.javafx.binding.StringFormatter;
Review comment:
`String.format` should serve the same purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3180: Fix the data loss issue caused by the cache expiration in PartitionerDataWriter
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3180:
URL: https://github.com/apache/incubator-gobblin/pull/3180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org