[GitHub] [superset] john-bodley commented on a diff in pull request #18609: fix: change database database selector

[GitBox <gi...@apache.org>]

john-bodley commented on code in PR #18609:
URL: https://github.com/apache/superset/pull/18609#discussion_r844476920


##########
superset-frontend/src/SqlLab/actions/sqlLab.js:
##########
@@ -787,7 +787,11 @@ export function queryEditorSetSchema(queryEditor, schema) {
 
     return sync
       .then(() =>
-        dispatch({ type: QUERY_EDITOR_SET_SCHEMA, queryEditor, schema }),
+        dispatch({
+          type: QUERY_EDITOR_SET_SCHEMA,
+          queryEditor: queryEditor || {},
+          schema: schema || {},

Review Comment:
   @pkdotson or @hughhhh this seems wrong, i.e., schema is a nullable string and not an object. Should this be `schema: schema || null`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org