You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "HBase Review Board (JIRA)" <ji...@apache.org> on 2010/07/08 01:55:49 UTC

[jira] Commented: (HBASE-2697) Implement new open/close logic in handlers and stop using heartbeats for open/close messages

    [ https://issues.apache.org/jira/browse/HBASE-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886157#action_12886157 ] 

HBase Review Board commented on HBASE-2697:
-------------------------------------------

Message from: "Jonathan Gray" <jg...@apache.org>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/282/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Just putting this up to show people.  It's not done but the balanceCluster() method "works" and has a bunch of test cases.


This addresses bug HBASE-2697.
    http://issues.apache.org/jira/browse/HBASE-2697


Diffs
-----

  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/HServerInfo.java 961064 
  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java PRE-CREATION 
  branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestLoadBalancer.java PRE-CREATION 

Diff: http://review.hbase.org/r/282/diff


Testing
-------

Added TestLoadBalancer.testLoadBalancer_balanceCluster().  If you have any good edge cases let me know!


Thanks,

Jonathan




> Implement new open/close logic in handlers and stop using heartbeats for open/close messages
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-2697
>                 URL: https://issues.apache.org/jira/browse/HBASE-2697
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, regionserver
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.21.0
>
>
> This issue is doing the meat of what HBASE-2485 is about and continues what was started in HBASE-2694 after some code cleanup to make life easier.
> This deals with no longer piggybacking messages from Master to RegionServers on heartbeat responses and instead sending direct unsolicited messages.  This also deals with moving the open/close logic fully into handlers and removing the existing open/close code on both the RS and M sides.  There may also be some changes to the master in-memory state of regions in transition.  The new load balancer will probably be introduced with this issue but not fully integrated yet.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.