You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/01/06 22:38:21 UTC
[Impala-ASF-CR] IMPALA-278: Mention DIV arithmetic operator.
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5634
Change subject: IMPALA-278: Mention DIV arithmetic operator.
......................................................................
IMPALA-278: Mention DIV arithmetic operator.
Also touch up the signatures of the related quotient() function,
which are looking a bit stale since the very early days.
Change-Id: I85093383ca6f32ba69f46fdf0220a1026e36f37f
---
M docs/topics/impala_math_functions.xml
M docs/topics/impala_operators.xml
2 files changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/5634/1
--
To view, visit http://gerrit.cloudera.org:8080/5634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85093383ca6f32ba69f46fdf0220a1026e36f37f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-278: Mention DIV arithmetic operator.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-278: Mention DIV arithmetic operator.
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/23/
--
To view, visit http://gerrit.cloudera.org:8080/5634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85093383ca6f32ba69f46fdf0220a1026e36f37f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-278: Mention DIV arithmetic operator.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-278: Mention DIV arithmetic operator.
......................................................................
IMPALA-278: Mention DIV arithmetic operator.
Also touch up the signatures of the related quotient() function,
which are looking a bit stale since the very early days.
Change-Id: I85093383ca6f32ba69f46fdf0220a1026e36f37f
Reviewed-on: http://gerrit.cloudera.org:8080/5634
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_math_functions.xml
M docs/topics/impala_operators.xml
2 files changed, 15 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85093383ca6f32ba69f46fdf0220a1026e36f37f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-278: Mention DIV arithmetic operator.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: IMPALA-278: Mention DIV arithmetic operator.
......................................................................
IMPALA-278: Mention DIV arithmetic operator.
Also touch up the signatures of the related quotient() function,
which are looking a bit stale since the very early days.
Change-Id: I85093383ca6f32ba69f46fdf0220a1026e36f37f
---
M docs/topics/impala_math_functions.xml
M docs/topics/impala_operators.xml
2 files changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/5634/2
--
To view, visit http://gerrit.cloudera.org:8080/5634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85093383ca6f32ba69f46fdf0220a1026e36f37f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-278: Mention DIV arithmetic operator.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-278: Mention DIV arithmetic operator.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85093383ca6f32ba69f46fdf0220a1026e36f37f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-278: Mention DIV arithmetic operator.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-278: Mention DIV arithmetic operator.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5634/1/docs/topics/impala_math_functions.xml
File docs/topics/impala_math_functions.xml:
Line 1053: This function is the same as the <codeph>DIV</codeph> operator.</ph>
would not say they are the same because DIV only accepts integers (and not floating-point values)
--
To view, visit http://gerrit.cloudera.org:8080/5634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85093383ca6f32ba69f46fdf0220a1026e36f37f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-278: Mention DIV arithmetic operator.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-278: Mention DIV arithmetic operator.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85093383ca6f32ba69f46fdf0220a1026e36f37f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No